Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rake Clean #654

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Rake Clean #654

merged 2 commits into from
Nov 14, 2024

Conversation

jasonkarns
Copy link
Collaborator

Bundler's built-in rake tasks add pkg/* to rake's CLOBBER list
(so rake clobber removes them).
That's great for .gem that are created via rake build because bundler's rake task writes the .gem to pkg/.
However, by default if you run gem build instead of rake build, you'll end up with the .gem written in the root (next to where the .gemspec is).
This adds *.gem to rake's CLOBBER list so that rake clobber will properly clean any built gems regardless if they were built via rake or gem.

(It also moves the default task to the top of the file rather than the bottom.
That's the conventional location inherited from make whose default task is automatically the first listed target.)

@searls searls merged commit 83daf21 into main Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants