Separate core types into stable crate #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the fundamental message-related traits and types into their own hedwig_core crate. This crate will have more version stability than the primary crate, which should allow less dependency churn when a set of message types are used across many crates. Further divisions of the library were considered. For example, it could be sensible to separate out hedwig-gcp, hedwig-prost, hedwig-json, etc. This would enable even better upgrade granularity, but at a maintenance cost. Both this repo and its users would then have to specify/coordinate/upgrade a plethora of crates to get a working system. Ultimately a smaller split of core+rest seems like a better compromise.
maroux
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the fundamental message-related traits and types into their own hedwig_core crate. This crate will have more version stability than the primary crate, which should allow less dependency churn when a set of message types are used across many crates.
Further divisions of the library were considered. For example, it could be sensible to separate out hedwig-gcp, hedwig-prost, hedwig-json, etc. This would enable even better upgrade granularity, but at a maintenance cost. Both this repo and its users would then have to specify/coordinate/upgrade a plethora of crates to get a working system. Ultimately a smaller split of core+rest seems like a better compromise.