Encapsulate std::complex functions #3122

SteveBronder · 2024-11-08T15:58:29Z

Summary

For the last few releases Stan math has had to do quick fixes when clang would update their functions for 'std::complex' which can cause conflicts when looking for our own functions that work over complex. The main issue for function calls like the following where an unqualified name lookup is used to find the correct function to call.

struct sin_fun {
  template <typename T>
  static inline auto fun(const T& x) {
    using std::sin;
    return sin(x);
  }
};

In the above, sin is looked for in both the stan::math namespace and the std namespace since unqualified name lookup also uses Argument Dependent Lookup (ADL). During ADL the compiler looks at the namespaces of the arguments as well as the local namespace to figure out all of the valid function signatures it should use when deciding which function is the best candidate. Since we override std::complex the std namespace is then also included in the valid candidates. Sometimes this is fine because the clang standard library uses requires very similar to ours for only supporting floating point types inside of their complex functions.

template <class _Tp, __enable_if_t<is_floating_point<_Tp>::value, int> >
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 complex<_Tp>
operator*(const complex<_Tp>& __lhs, const complex<_Tp>& __rhs) {
  return complex<_Tp>(__from_builtin_tag(), __lhs.__builtin() * __rhs.__builtin());
}

But some functions, like the one below (linked here), do not restrict themselves to only floating point types.

template <class _Tp>
inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 complex<_Tp> conj(const complex<_Tp>& __c) {
  return complex<_Tp>(__c.real(), -__c.imag());
}

This causes issues because ADL then finds two valid candidates functions when trying to find the best candidate for conj (both the stan::math version and the std version).

There is no good solution to this issue, it's just how the language is defined. The only way to make stan::math functions a better candidate is to use templates to make the stan math function both more generic and have an extra template with our requires which makes it slightly better so the compiler chooses it as the best candidate.

So this PR does a few things.

Use templates for all of the std functions that we want to override for complex types. The generic template and parameters makes our functions a better candidate.
- This is very much a patch solution. In the long run we need our own custom complex scalar type. But we can't do that yet till an issue is resolved in eigen (see here) where they assume users are overriding std::complex for their complex types.
Cleans up the vectorized functions signatures. There were 4 or 5 different requires being used and they made the function rather confusing. Most of the vectorized functions work over containers containing base types of autodiff so we can just use one requires instead of the several that were there
Fixes the headers in rev so that rev headers are always used first and if available. This stops issues with prim being brought in before their respective rev or fwd functions are available and fixes soem header include order issues.

Tests

No changes to tests

Side Effects

Hopefully not

Release notes

Template complex functions in the Stan math library to be better candidates than the standard library functions during ADL.

Checklist

Copyright holder: Simons Foundation

The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
- unit tests pass (to run, use: ./runTests.py test/unit)
- header checks pass, (make test-headers)
- dependencies checks pass, (make test-math-dependencies)
- docs build, (make doxygen)
- code passes the built in C++ standards checks (make cpplint)
the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested

SteveBronder · 2024-11-08T15:59:25Z

Also after this release I'm going to write a script that we can use in jenkins to check that includes are being done correctly

WardBrian · 2024-11-08T20:00:20Z

Tagging #3006 just so this PR shows up in the history of that issue -- as you say, actually resolving it would require Eigen to make some changes first

WardBrian · 2024-11-08T21:29:30Z

Running with latest compilers: https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FBleedingEdgeCompilersMonthly/detail/BleedingEdgeCompilersMonthly/235/pipeline

WardBrian

A bunch of tiny questions/comments -- thanks for tackling this!

stan/math/fwd/fun/atan2.hpp

stan/math/fwd/fun/conj.hpp

stan/math/fwd/fun/inv_sqrt.hpp

stan/math/fwd/fun/tan.hpp

stan/math/prim/meta/is_container.hpp

stan/math/prim/fun/asinh.hpp

stan/math/prim/fun/atanh.hpp

stan/math/prim/fun/conj.hpp

stan/math/prim/fun/inv_cloglog.hpp

stan/math/prim/fun/inv_sqrt.hpp

…ion.

WardBrian

A few small things in the new fwd changes, plus the above comments on doc seem to be outstanding

stan/math/fwd/fun/hypergeometric_1F0.hpp

stan/math/fwd/fun/inv_sqrt.hpp

stan/math/fwd/fun/log_mix.hpp

WardBrian · 2024-11-13T16:45:29Z

stan/math/fwd/fun/tcrossprod.hpp

 #include <stan/math/prim/fun/to_ref.hpp>
 #include <stan/math/prim/fun/transpose.hpp>
-#include <stan/math/fwd/fun/multiply.hpp>
+#include <stan/math/prim/fun/multiply.hpp>


Was this meant to be a deletion?

No sorry we are supposed to use multiply in this function.

multiply returns a scalar for multiply(vector, row_vector). Should this function also return a scalar in the case of a vector?

We’re including the fwd multiply higher up

^yes. What about the second part of my Q. I think it should return the same thing as multiply?

I think this should always return a Eigen::Matrix to match prim, rev, etc. so the latest looks correct?

stan-buildbot · 2024-11-14T02:36:35Z

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
arma/arma.stan	0.4	0.36	1.1	9.3% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	1.15	12.98% faster
gp_regr/gen_gp_data.stan	0.03	0.03	1.05	5.04% faster
gp_regr/gp_regr.stan	0.11	0.1	1.07	6.78% faster
sir/sir.stan	73.25	72.1	1.02	1.56% faster
irt_2pl/irt_2pl.stan	4.45	4.55	0.98	-2.34% slower
eight_schools/eight_schools.stan	0.06	0.06	1.0	0.14% faster
pkpd/sim_one_comp_mm_elim_abs.stan	0.27	0.26	1.03	2.48% faster
pkpd/one_comp_mm_elim_abs.stan	20.53	20.79	0.99	-1.27% slower
garch/garch.stan	0.49	0.44	1.12	10.96% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.9	2.76	1.05	4.86% faster
arK/arK.stan	1.94	1.8	1.08	7.54% faster
gp_pois_regr/gp_pois_regr.stan	2.97	2.84	1.04	4.15% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	9.33	8.73	1.07	6.48% faster
performance.compilation	202.13	196.63	1.03	2.72% faster
Mean result: 1.0520756654774657

Jenkins Console Log
Blue Ocean
Commit hash: 33e2a9b0643b749c04e63d6ae4d820d17920d0d6

Machine information

No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 3349.670
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

WardBrian · 2024-11-14T17:30:40Z

@SteveBronder I addressed all my own docstring comments, so it's just the ~6 things above that are unresolved, including ones from my original review which are unfortunately "hidden" by github and you need to click to expand

stan-buildbot · 2024-11-15T00:35:41Z

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
arma/arma.stan	0.38	0.32	1.18	14.97% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	1.02	1.97% faster
gp_regr/gen_gp_data.stan	0.03	0.03	1.1	9.03% faster
gp_regr/gp_regr.stan	0.1	0.1	1.05	4.82% faster
sir/sir.stan	69.98	73.17	0.96	-4.56% slower
irt_2pl/irt_2pl.stan	4.18	4.4	0.95	-5.15% slower
eight_schools/eight_schools.stan	0.06	0.06	1.01	0.76% faster
pkpd/sim_one_comp_mm_elim_abs.stan	0.25	0.25	1.0	0.06% faster
pkpd/one_comp_mm_elim_abs.stan	19.55	19.8	0.99	-1.28% slower
garch/garch.stan	0.44	0.41	1.06	5.96% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.82	2.65	1.06	6.05% faster
arK/arK.stan	1.85	1.73	1.07	6.49% faster
gp_pois_regr/gp_pois_regr.stan	2.89	2.94	0.98	-1.64% slower
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	9.17	8.72	1.05	4.88% faster
performance.compilation	186.31	192.73	0.97	-3.45% slower
Mean result: 1.029879563409019

Jenkins Console Log
Blue Ocean
Commit hash: 699a5e6931000a42a5e00f93fc9c2e56cc9c7f48

Machine information

No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 3630.709
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

stan-buildbot · 2024-11-15T06:01:24Z

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
arma/arma.stan	0.37	0.34	1.1	8.97% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	1.09	8.52% faster
gp_regr/gen_gp_data.stan	0.03	0.03	1.08	7.42% faster
gp_regr/gp_regr.stan	0.1	0.1	1.05	4.35% faster
sir/sir.stan	73.82	74.0	1.0	-0.24% slower
irt_2pl/irt_2pl.stan	4.79	4.53	1.06	5.38% faster
eight_schools/eight_schools.stan	0.06	0.06	0.98	-1.84% slower
pkpd/sim_one_comp_mm_elim_abs.stan	0.27	0.27	1.0	0.41% faster
pkpd/one_comp_mm_elim_abs.stan	20.85	20.59	1.01	1.24% faster
garch/garch.stan	0.5	0.46	1.08	7.34% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.93	2.82	1.04	3.96% faster
arK/arK.stan	1.97	2.05	0.96	-3.88% slower
gp_pois_regr/gp_pois_regr.stan	2.97	3.27	0.91	-10.22% slower
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	9.45	9.2	1.03	2.6% faster
performance.compilation	194.99	195.07	1.0	-0.04% slower
Mean result: 1.0258068981838957

Jenkins Console Log
Blue Ocean
Commit hash: 699a5e6931000a42a5e00f93fc9c2e56cc9c7f48

Machine information

No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

WardBrian · 2024-11-15T15:06:08Z

@SteveBronder final check -- good to merge?

…d-complex

stan-buildbot · 2024-11-16T11:46:43Z

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
arma/arma.stan	0.32	0.3	1.04	4.24% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	1.09	7.87% faster
gp_regr/gen_gp_data.stan	0.03	0.03	1.04	3.65% faster
gp_regr/gp_regr.stan	0.12	0.09	1.32	24.09% faster
sir/sir.stan	69.63	70.65	0.99	-1.47% slower
irt_2pl/irt_2pl.stan	4.21	4.19	1.0	0.42% faster
eight_schools/eight_schools.stan	0.06	0.06	0.99	-1.06% slower
pkpd/sim_one_comp_mm_elim_abs.stan	0.25	0.25	1.0	-0.02% slower
pkpd/one_comp_mm_elim_abs.stan	19.65	19.13	1.03	2.62% faster
garch/garch.stan	0.44	0.41	1.07	6.61% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.74	2.59	1.06	5.49% faster
arK/arK.stan	1.8	1.71	1.05	5.06% faster
gp_pois_regr/gp_pois_regr.stan	2.9	2.73	1.06	6.06% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	8.88	8.44	1.05	4.89% faster
performance.compilation	181.82	183.21	0.99	-0.76% slower
Mean result: 1.0520958029441665

Jenkins Console Log
Blue Ocean
Commit hash: 8dc1c9455d14e7e5b86be01f64c7bf0e84ec1fc9

Machine information

No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 3214.537
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

syclik · 2024-11-16T17:46:30Z

@SteveBronder awesome!!!

SteveBronder added 5 commits November 5, 2024 17:38

testing encapsulation of std complex

f87e167

fix all headers in rev

2f225e2

add docs for all new functions

68c3681

fix conj

58fdd14

fix complex conj

1968994

[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1

d0b650c

SteveBronder added 2 commits November 8, 2024 15:29

fix double header includes

c7892d6

fix docs

cd54411

update fwd includes

37a5e71

WardBrian requested changes Nov 11, 2024

View reviewed changes

SteveBronder added 2 commits November 11, 2024 17:05

update includes for fwd to always prefer fwd version before prim vers…

83cf7d7

…ion.

update includes for fwd to always prefer fwd version before prim vers…

c15aeae

…ion.

WardBrian requested changes Nov 13, 2024

View reviewed changes

Docstring duplication and edits

9a6a4ec

SteveBronder and others added 4 commits November 14, 2024 17:10

update header includes

2bc815c

Merge commit '4a812be023c2b98c4ef97999985fd947cfc895fa' into HEAD

7bc6c81

[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1

754547c

update header includes

d6ff92d

SteveBronder added 4 commits November 15, 2024 14:07

fix headers

a289886

Merge remote-tracking branch 'origin/develop' into fix/encapsulate-st…

a0f26b8

…d-complex

update headers

4c84cfb

update headers

65770d7

[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1

8b26bc5

WardBrian previously approved these changes Nov 15, 2024

View reviewed changes

cpplint fix

7cf039a

WardBrian dismissed their stale review via 7cf039a November 15, 2024 21:58

WardBrian approved these changes Nov 15, 2024

View reviewed changes

WardBrian merged commit baae551 into develop Nov 18, 2024
8 checks passed

WardBrian deleted the fix/encapsulate-std-complex branch November 18, 2024 13:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Encapsulate std::complex functions #3122

Encapsulate std::complex functions #3122

SteveBronder commented Nov 8, 2024 •

edited

Loading

SteveBronder commented Nov 8, 2024

WardBrian commented Nov 8, 2024

WardBrian commented Nov 8, 2024

WardBrian left a comment

WardBrian left a comment

WardBrian Nov 13, 2024

SteveBronder Nov 14, 2024

WardBrian Nov 14, 2024

SteveBronder Nov 14, 2024 •

edited

Loading

WardBrian Nov 15, 2024

stan-buildbot commented Nov 14, 2024

WardBrian commented Nov 14, 2024 •

edited

Loading

stan-buildbot commented Nov 15, 2024

stan-buildbot commented Nov 15, 2024

WardBrian commented Nov 15, 2024

stan-buildbot commented Nov 16, 2024

syclik commented Nov 16, 2024

Encapsulate std::complex functions #3122

Encapsulate std::complex functions #3122

Conversation

SteveBronder commented Nov 8, 2024 • edited Loading

Summary

Tests

Side Effects

Release notes

Checklist

SteveBronder commented Nov 8, 2024

WardBrian commented Nov 8, 2024

WardBrian commented Nov 8, 2024

WardBrian left a comment

Choose a reason for hiding this comment

WardBrian left a comment

Choose a reason for hiding this comment

WardBrian Nov 13, 2024

Choose a reason for hiding this comment

SteveBronder Nov 14, 2024

Choose a reason for hiding this comment

WardBrian Nov 14, 2024

Choose a reason for hiding this comment

SteveBronder Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

WardBrian Nov 15, 2024

Choose a reason for hiding this comment

stan-buildbot commented Nov 14, 2024

WardBrian commented Nov 14, 2024 • edited Loading

stan-buildbot commented Nov 15, 2024

stan-buildbot commented Nov 15, 2024

WardBrian commented Nov 15, 2024

stan-buildbot commented Nov 16, 2024

syclik commented Nov 16, 2024

SteveBronder commented Nov 8, 2024 •

edited

Loading

SteveBronder Nov 14, 2024 •

edited

Loading

WardBrian commented Nov 14, 2024 •

edited

Loading