Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mcse plots similar to neff and rhat plots #278

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Oct 7, 2021

This PR is not new, just a reworked version of PR #210 from @VeenDuco. For some reason that PR got messed up and it lists 223 files changed when there should only be a few. This separate PR includes what I think were the intended changes from @VeenDuco, which I had already looked at and approved (so I think this is ready to go). I also added a few tests.

@VeenDuco would you mind taking a quick look at this before I merge it?

@VeenDuco
Copy link

Hey @jgabry, I think most looks good. Only in R/mcmc-diagnostics.R there are still some occurrences of labels = c("low", "ok", "high") instead of labels = c("low", "mid", "high"). I think everywhere else ok was replaced with mid. Everything else is a quite straightforward adaptation of the other functions and looks good.

Copy link

@VeenDuco VeenDuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jgabry, I think most looks good. Only in R/mcmc-diagnostics.R there are still some occurrences of labels = c("low", "ok", "high") instead of labels = c("low", "mid", "high"). I think everywhere else ok was replaced with mid. Everything else is a quite straightforward adaptation of the other functions and looks good.

Also in man/MCMC-diagnostics.Rd some occurances of ok description, but I think those are fine to keep.

@jgabry
Copy link
Member Author

jgabry commented Oct 12, 2021

Thanks @VeenDuco.

Only in R/mcmc-diagnostics.R there are still some occurrences of labels = c("low", "ok", "high") instead of labels = c("low", "mid", "high").

Can you point me to where you still see "ok" in the code? I can't seem to find it. Thanks! (I agree it's fine to keep "ok" in the doc)

@VeenDuco
Copy link

My bad, those were still there in the commit ccdac30 but corrected in adecf0b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants