Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added generic description based on device generic/specific code #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stamp
Copy link
Member

@stamp stamp commented May 23, 2017

Also fixed a couple of nil pointer exceptions

Also fixed a couple of nil pointer exceptions
@codecov-io
Copy link

codecov-io commented May 23, 2017

Codecov Report

Merging #29 into master will decrease coverage by 0.1%.
The diff coverage is 31.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   59.83%   59.73%   -0.11%     
==========================================
  Files          36       36              
  Lines        1845     1855      +10     
==========================================
+ Hits         1104     1108       +4     
- Misses        715      721       +6     
  Partials       26       26
Impacted Files Coverage Δ
generators/commandclasses/commandclasses.go 0% <0%> (ø) ⬆️
connection.go 66.66% <16.66%> (-0.35%) ⬇️
nodes/node.go 23.49% <57.14%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c389b24...aa08baf. Read the comment docs.

@lukescott
Copy link
Collaborator

lukescott commented Sep 17, 2017

@stamp, are all these commits based on the original PR?

@stamp
Copy link
Member Author

stamp commented Oct 2, 2017 via email

@lukescott
Copy link
Collaborator

@stamp, ignore me, I responded to the wrong PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants