-
Notifications
You must be signed in to change notification settings - Fork 539
WIP: Add link to documentation #33
base: master
Are you sure you want to change the base?
Conversation
…r the operator label. Note cannot click on link at the moment as elevation2before and elevation2after blocking click event somehow.
Ah, I was about to file an issue about this--as a beginner to RxJS, I would find this really helpful. Thanks for working on it @ichpuchtli! |
People looking at rxmarbles do not come from RxJs only but all kind of languages. |
marginTop: '5px' | ||
}; | ||
let operatorName = label.split('(')[0].toLowerCase(); | ||
let href = `https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/operators/${operatorName}.md`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the url to simply "http://reactivex.io/documentation/operators/${operatorName}.html"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would broaden the documentation to other languages. Also, there's information and links to different languages. e.g. http://reactivex.io/documentation/operators/debounce.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to all the operators map to reactivex.io. Maybe an effort could be made to duplicated this for xstream and rxjs5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, don't all operators map to the generic documentation?
Just a starting point. Might look better with the link under sandbox. Note cannot click on link at the moment as elevation2before and elevation2after blocking click event somehow.