Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Clojurescript + re-frame solution #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clojurescript + re-frame solution #57

wants to merge 1 commit into from

Conversation

decoursin
Copy link

Here's my commits: https://github.com/decoursin/flux-challenge.

Thank you!

@staltz
Copy link
Owner

staltz commented Jan 13, 2016

Hi, thanks for the submission.

Problems:

This flickering should not happen when the page is loaded:
decoursin

And the up scroll button should have been enabled in this case:
screen shot 2016-01-13 at 19 43 56

@decoursin
Copy link
Author

The up button is disabled because the up/down buttons are reverse -- what I mean is that, compared to the images on the readme, up goes the other way. When you're down arrow is disabled, my up arrow is disabled. So it's either a problem that my arrows go the wrong way, or you're ok with it.

I'm a little confused what you mean by flickering. Are you talking about the planets at the top?

@staltz
Copy link
Owner

staltz commented Jan 13, 2016

You can just compare your submissions to other submissions. They should all work in the same way.

@decoursin
Copy link
Author

decoursin commented Jan 13, 2016

Well, we know they don't all work exactly the same way. Yes, I can change it. I've never seen that flickering, though, so I don't know what that's about, which is why I asking about it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants