-
Notifications
You must be signed in to change notification settings - Fork 208
Typescript retozi #21
base: master
Are you sure you want to change the base?
Conversation
Not working. Check other submissions to see how they work. |
In what sense? I did cross compare and it seems to behave the same way, did it not load at all or did you somehow enter an invalid state with the up and down scrolling? |
I have fixed an issue that leaves you in a semi recoverable state when you get unlucky with the Obi Wans planet, request canceling and scrolling. You might have hit that right when you started testing. I really cannot find any other difference, I compared it to @tomkis1 solution excessively and I cannot find any difference to it, it behaves exactly the same way except that my solution allows for two scrolldowns. |
Jesus man I suck. Should have seen that... sorry for wasting your time by only testing when clicking up first :) |
Some problems still:
|
|
This is done to avoid entering uncharted territory. It is stated that only one request after another should be fired. If I enable the upscroll here, it would technically mean that two requests could be pending at the same time. (request triggering going up and going down the list would be independent). From the feel of it, hyperturtle's solution does exactly this (although I have not verified it in the code). If this is okey, I will enable this. alternatively I could
please advise |
A Typescript implementation without any external dependencies
simply run the server and open index.html in a browser.
or then
for a dev server