Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Tests] - MakeConnectionCodeRequest #2372

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MahtabBukhari
Copy link
Contributor

Describe your changes

Issue ticket number: #2355

Link

Close: #2355

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@elraphty
Copy link
Contributor

elraphty commented Jan 9, 2025

@MahtabBukhari the unit/integration test is failing

@MahtabBukhari
Copy link
Contributor Author

MahtabBukhari commented Jan 9, 2025

@elraphty basically unit tests are failing due to not having botV2Url

for making connection code
what we can use as it is an ENV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Unit Tests] - MakeConnectionCodeRequest
2 participants