feat: modfied action to take log and save it when error #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevkevinpal
force-pushed
the
captureLogsAndPushToStakwork
branch
27 times, most recently
from
07c0d07 to
87eab6e
Compare
|
This should resolve this issue |
kevkevinpal
force-pushed
the
captureLogsAndPushToStakwork
branch
2 times, most recently
from
f840160 to
6ac80ba
Compare
kevkevinpal
force-pushed
the
captureLogsAndPushToStakwork
branch
from
6ac80ba to
e88c2ac
Compare
kevkevinpal
force-pushed
the
captureLogsAndPushToStakwork
branch
from
e88c2ac to
78664cb
Compare
|
This also closes #2172 |
|
@kevkevinpal - Hey mate - quick heads up this seemed to break the web socket functionality on the local and staging servers so we've commented it out in this PR to resolve: #2190 When you're online can you touch base with @elraphty / @tobi-bams so we can understand what we need to change to reapply safely? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This change adds a new middleware which currently catches if there is an internal server error then writes to the logs
Issue ticket number and link
#2116