[Unit Tests] - VerifyTribeUUID #2096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elraphty
requested changes
Dec 5, 2024
| } | ||
|
|
||
| return pubkey, nil | ||
| } |
There was a problem hiding this comment.
@MahtabBukhari, this function has already been declared in auth.go, why redeclare it here?
There was a problem hiding this comment.
@elraphty @tomsmith8 Here we have to redeclare "VerifyTribeUUID" because it is using these you method in his body
"ParseTokenString", "VerifyAndExtract" for mocking these two method then we also have to use in "VerifyTribeUUID" to check the tests only for "VerifyTribeUUID"
When we use the original "VerifyTribeUUID" then the unit tests are not going to be pass in any way
Please guide me what would be the best way now?
There was a problem hiding this comment.
You have to create a real signature, you are trying to bypass testing the original function, check out #2113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.