-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT]: Workflow Response: Routes, Handler & Processing Utils #1955
[FEAT]: Workflow Response: Routes, Handler & Processing Utils #1955
Conversation
Hi @humansinstitute, Please review this PR. |
Seems to me that we're missing the util functions here to follow the format in the design? |
Hi @humansinstitute, @tobi-bams, @elraphty, The processing functionality is already implemented in our current codebase. In
sphinx-tribes/handlers/workflow.go Line 93 in 6d75668
All the required fields (Source, RequestID, Action, WorkflowID, RequestData, ResponseData) are already handled in our The only difference is that instead of having this in a
@tobi-bams, @elraphty, could you please review this PR? |
@tobi-bams could you take a look at this and approve? |
handlers/workflow.go
Outdated
} | ||
|
||
var response struct { | ||
RequestID string `json:"request_id"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This struct should only be requestUUID
and responseData
.
handlers/workflow.go
Outdated
return | ||
} | ||
|
||
switch response.Status { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this switch
block
handlers/workflow.go
Outdated
return | ||
} | ||
|
||
status := response.Status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The status here should be completed automatically
Describe the chnages:
closes: #1941
closes: #1942
closes: #1943
Issue ticket number and link:
Evidence:
Checklist before requesting a review