Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Reversal Payments Functionality #1936

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

elraphty
Copy link
Contributor

Describe your changes

This PR Adds the payment reversal functionality.

Issue ticket number and link

Closes #1905

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox

Copy link
Contributor

@Evanfeenstra Evanfeenstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u help me understand what stops ProcessReversePayments from being called twice on the same failed payment?

@elraphty
Copy link
Contributor Author

Can u help me understand what stops ProcessReversePayments from being called twice on the same failed payment?

Can u help me understand what stops ProcessReversePayments from being called twice on the same failed payment?

It only reverses bounties payments that were PENDING then become FAILED after checking for payment status, If the bounty payment has been paid, or failed it won't process reversal.

@Evanfeenstra
Copy link
Contributor

can u link the specific line that stops the v2_payments_cron from being run twice on the same payment?

@elraphty
Copy link
Contributor Author

can u link the specific line that stops the v2_payments_cron from being run twice on the same payment?

https://github.com/stakwork/sphinx-tribes/pull/1936/files#diff-9149ba04ad6447f03cc0ba39d5c051944e26b65d7983cd1554125984da74c738L965-R978 Only pending payments go through

@elraphty
Copy link
Contributor Author

can u link the specific line that stops the v2_payments_cron from being run twice on the same payment?

This also gets only pending payments https://github.com/stakwork/sphinx-tribes/pull/1936/files#diff-1b0417ad22cdb9ca66636481007174e1ce62f773dd61df8fea67f4937712a376R16

@Evanfeenstra
Copy link
Contributor

looks good, i get it now

Last thing is that if its just pending for a week, than we need to do the same thing. Lets do that in a differnet PR tho

@elraphty elraphty force-pushed the feat/payment_reversal branch from 0c3a184 to f290d87 Compare November 14, 2024 18:09
@Evanfeenstra Evanfeenstra merged commit 085e0d8 into master Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Reversal after Failed payments
2 participants