Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add Last Withdrawal, and Total Amount of Deposits Greater OR Equals Conditions #1893

Merged
merged 24 commits into from
Oct 21, 2024
Merged

PR: Add Last Withdrawal, and Total Amount of Deposits Greater OR Equals Conditions #1893

merged 24 commits into from
Oct 21, 2024

Conversation

elraphty
Copy link
Contributor

@elraphty elraphty commented Oct 17, 2024 •
edited
Loading

Describe your changes

This PR adds a condition to check that the last budget withdrawal time is greater than 1 one, it also checks that the sum of all the deposits In a workspace is greater than the sum of all withdrawals plus amount the user wants to withdraw

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox

elraphty added 22 commits October 17, 2024 09:12
@elraphty
added convert to timestamp function and test
9cd89fc
@elraphty
tested get hours difference
9f8b6fc
@elraphty
test time to hours
e83226d
@elraphty
added function
a300c68
@elraphty
checked for sum of deposits and withdrawals
1720006
@elraphty
check that user has done a withdrawal
3cd4997
@elraphty
fixed withdraw bug
a29a7fd
@elraphty
fixed hour check error
fccbcfe
@elraphty
added payment_history to 400 test error
99887b1
@elraphty
sleep after 2 seconds after adding payment to histiry
7efdd30
@elraphty
push ater passing locally
bf8501e
@elraphty
added to see the workspace_uuid in test
7324154
@elraphty
add ageneral late time
92739a4
@elraphty
add general greater time to fix
27b9e5e
@elraphty
revert after testing positive time additions
c9d482f
@elraphty
revert after testing positive time additions
ed38f22
@elraphty
mocked getHoursDifference
f0bf975
@elraphty
mocked getHours for withdraw bounty
fb21888
@elraphty
revert to default test config
4803f35
@elraphty
after security checks
f4e1988
@elraphty
changed db to default
f2d729b
@elraphty
removed invoice settlement check from handler
d26873f
@elraphty elraphty requested a review from Evanfeenstra October 18, 2024 17:42
Evanfeenstra
Evanfeenstra reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@Evanfeenstra Evanfeenstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing getLightningInvoice into ProcessUpdateBudget does not work. It must be part of the transaction in order to be atomic. I mean, it must use the tx to query

@elraphty
Copy link
Contributor Author

Passing getLightningInvoice into ProcessUpdateBudget does not work. It must be part of the transaction in order to be atomic. I mean, it must use the tx to query

Oh! thank @Evanfeenstra, I have made that change, can you please highlight the line, I tried searching locally but couldn't find it.

@Evanfeenstra
Copy link
Contributor

you already made the other change previously. Go ahead and merge this PR @elraphty

@elraphty
Copy link
Contributor Author

you already made the other change previously. Go ahead and merge this PR @elraphty

Okay, nice

@elraphty elraphty merged commit 52357d9 into master Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evanfeenstra Evanfeenstra Evanfeenstra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elraphty @Evanfeenstra