Refactor TestGetPersonByPuKey To Use A Real Postgres DB For The Test #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elraphty
reviewed
Jun 20, 2024
handlers/people_test.go
Outdated
| rctx := chi.NewRouteContext() | ||
| rctx.URLParams.Add("pubkey", "person-pub-key") | ||
| req, err := http.NewRequestWithContext(context.WithValue(context.Background(), chi.RouteCtxKey, rctx), http.MethodGet, "/person/person-pub-key", nil) | ||
| rctx.URLParams.Add("pubkey", "person_104_pubkey") |
There was a problem hiding this comment.
@MuhammadUmer44 please use the variable person.OwnerPubkey here, this will help for an easy change in the future, and you don't need to reuse the same string when it is already on a variable.
rctx.URLParams.Add("pubkey", person.OwnerPubkey)There was a problem hiding this comment.
@MuhammadUmer44 please use the variable
person.OwnerPubkeyhere, this will help for an easy change in the future, and you don't need to reuse the same string when it is already on a variable.rctx.URLParams.Add("pubkey", person.OwnerPubkey)
also use the person.OwnerPubkey on the route.
There was a problem hiding this comment.
@elraphty Fixed.
|
Hi @elraphty, Please review this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Closes: #1713
Checklist before requesting a review