Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phases to Features #1642

Merged
merged 16 commits into from
May 15, 2024

Conversation

MahtabBukhari
Copy link
Contributor

@MahtabBukhari MahtabBukhari commented May 13, 2024

Describe your changes

close: #1638

image

image

Issue

  • Ticket Number: 1638
  • Link

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@MahtabBukhari
Copy link
Contributor Author

@fvalentiner @elraphty Could you please reivew this PR?

@MahtabBukhari MahtabBukhari changed the title Add Phases to Features Implementation: Add Phases to Features May 14, 2024
@MahtabBukhari MahtabBukhari changed the title Implementation: Add Phases to Features Add Phases to Features May 14, 2024
@MahtabBukhari MahtabBukhari requested a review from elraphty May 14, 2024 18:08
handlers/features.go Outdated Show resolved Hide resolved
@@ -35,7 +35,7 @@ describe('Modify phases name', () => {
}).its('body').then(body => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MahtabBukhari change 06_phases.cy.js to cypress/e2e/06_phases.cy.ts, everything else is fine now thanks.

@MahtabBukhari MahtabBukhari requested a review from elraphty May 15, 2024 00:36
@elraphty elraphty force-pushed the feature-add-phases branch from 1d07883 to 50cc848 Compare May 15, 2024 05:42
@elraphty elraphty merged commit 0ef119d into stakwork:feature-add-phases May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants