Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bounty Providers Endpoint #1591

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Added Bounty Providers Endpoint #1591

merged 1 commit into from
Mar 6, 2024

Conversation

elraphty
Copy link
Contributor

@elraphty elraphty commented Mar 6, 2024

Describe your changes

This feature adds a bounty providers list endpoint.

Issue ticket number and link

Closes #1589

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device

@kevkevinpal
Copy link
Contributor

@elraphty do you think we need a new endpoint or should we just add a query param to filter where we needed on this PR stakwork/sphinx-tribes-frontend#341

@kevkevinpal
Copy link
Contributor

In this PR we are adding a query param for providers
https://github.com/stakwork/sphinx-tribes-frontend/pull/341/files#diff-b99fbceed6dc4aa0085944eae64088cc235ec10e88d81c8e40a721fb1949624cR93

for the /metrics/bounties endpoint, we should only return metrics with that provider

https://github.com/stakwork/sphinx-tribes/blob/master/routes/metrics.go#L21

@kevkevinpal
Copy link
Contributor

do you think we should fix the endpoint using the query param instead of creating a new endpoint?

@kevkevinpal
Copy link
Contributor

ohh wait nvm disregard my previous comments it makes sense why we'd need this endpoint for it to work with the frontend now

@elraphty
Copy link
Contributor Author

elraphty commented Mar 6, 2024

ohh wait nvm disregard my previous comments it makes sense why we'd need this endpoint for it to work with the frontend now

Yeah, the provider's list for the bounties is just to select bounties for certain providers, but we need a paginated list of providers based on the date range and status selected on the provider's modal.

Copy link
Contributor

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minus the one comment

@elraphty elraphty merged commit 24d1e1f into master Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new endpoint to filter for providers for super admin
2 participants