Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit test for MakeBountyPayment #1580

Closed
wants to merge 2 commits into from

Conversation

gouravmpk
Copy link
Contributor

Describe your changes

Added Unit test for MakeBountyPayment

Issue ticket number and link

Backend [Integration Test] bounty.go handlers MakeBountyPayment #1564

Type of change

Unit test

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ran unit test locally

ID: 12,
Type: "coding",
Title: "first bounty",
Description: "first bounty description",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gouravmpk I can't see you mocking the relay calls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elraphty had a discussion with @ecurrencyhodler regarding this issue this test is already done by someone

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elraphty had a discussion with @ecurrencyhodler regarding this issue this test has already done by someone

No, it is not, I broke down the test cases into 2 issues, @MirzaHanan worked on the first part, this is supposed to be the second part.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I will add it there asap

@elraphty elraphty closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants