Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable correct filtering when status is selected in superadmin #1512

Merged

Conversation

AbdulWahab3181
Copy link
Contributor

Describe your changes

https://www.loom.com/share/dae0d620a10b49c6a6f30d111f846c2e

Issue ticket number and link

closes #1511

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@AbdulWahab3181 AbdulWahab3181 marked this pull request as ready for review February 14, 2024 15:04
@aliraza556
Copy link
Contributor

aliraza556 commented Feb 14, 2024

Hi @AbdulWahab3181
The video looks good to me (LGTM)! Let's proceed with the code review.

I examined the problem and the related code modifications. Additionally, I performed local testing to confirm that all is functioning as intended without impacting other features.

@elraphty elraphty merged commit d37c4e0 into stakwork:master Feb 14, 2024
1 check passed
@ecurrencyhodler
Copy link
Contributor

Great job. Thanks for the quick turnaround. Paid 200k sats: https://community.sphinx.chat/bounty/1483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable correct filtering when status is selected in superadmin
4 participants