fix(people): use unique id person property for key
#1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are duplicated items in people data with the same `owner_pubkey`. These items leads to duplicating cards in the search result. Use `id` field as it is strongly unique. Fix: stakwork#1436
|
@ecurrencyhodler this one is ready for test and review P.S. The strange behaviour was tricky and prosaic simultaniously |
|
video LGTM. Let's get a code review |
|
Tested and it works. GJ. Paid! |
elraphty
added a commit
that referenced
this pull request
Jan 26, 2024
…s-from-people-search-result fix(people): use unique `id` person property for `key`
elraphty
added a commit
that referenced
this pull request
Jan 26, 2024
…s-from-people-search-result fix(people): use unique `id` person property for `key`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
There are duplicated items in people data with the same
owner_pubkey. These items leads to duplicating cards in the search result. Useidfield as it is strongly unique.Issue ticket number and link
Fix: #1436
Type of change
Bug fix (non-breaking change which fixes an issue)
https://jam.dev/c/051c20e9-b431-4fff-84cb-6fc20fece577