Updated delete organization endpoint functionality and implemented tests #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
There are a couple of conflicting files: |
Resolved |
|
LGTM! Good job. Let's get a code review. |
elraphty
reviewed
Jan 18, 2024
db/db.go
Outdated
|
|
||
| func (db database) UpdateOrganizationForDeletion(uuid string) error { | ||
| updates := map[string]interface{}{ | ||
| "website": nil, |
There was a problem hiding this comment.
@AbdulWahab3181 change all nil to empty strings ""
handlers/organization_test.go
Outdated
| OwnerPubKey: "test-key", | ||
| Website: nil, | ||
| Github: nil, | ||
| Description: nil, |
There was a problem hiding this comment.
@AbdulWahab3181 change all nil to empty strings ""
There was a problem hiding this comment.
Follow Raph's advice here @AbdulWahab3181
|
Nice work. Paid! |
elraphty
added a commit
that referenced
this pull request
Jan 26, 2024
Updated delete organization endpoint functionality and implemented tests
elraphty
added a commit
that referenced
this pull request
Jan 26, 2024
Updated delete organization endpoint functionality and implemented tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
5d1cb6a7-b096-4779-b9a7-014ef28e5888.mp4
Issue ticket number and link
Closes #1334
Type of change
Please delete options that are not relevant.
Checklist before requesting a review