Description len check #1354
Merged
Description len check #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @elraphty my tests are passing but failing due to coverage maybe . |
I see this failing You might need to add a desc to that test since this change adds a new requirement |
|
@kevkevinpal thanks for the input |
|
All checks passed. Let's get a code review. |
|
@gouravmpk please fix merge conflicts |
|
Resolved @elraphty |
|
@elraphty after resolving conflicts test is failing can you tell |
|
@elraphty fixed merge conflicts and breaking tests |
|
Paid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
added check for description 120 char
added test
Issue ticket number and link
#1322
Type of change
Checklist before requesting a review