Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test for Mark as Unpaid button #1325

Closed
wants to merge 23 commits into from

Conversation

gouravmpk
Copy link
Contributor

Describe your changes

Added test case (Don't merge)

Issue ticket number and link

#1196

Type of change

Unit test

@ecurrencyhodler
Copy link
Contributor

You have some conflicting files @gouravmpk can you resolve?

@gouravmpk
Copy link
Contributor Author

gouravmpk commented Jan 10, 2024

@ecurrencyhodler
"Only those with write access to this repository can merge pull requests."

image

getting this message

@ecurrencyhodler
Copy link
Contributor

Screenshot 2024-01-10 at 12 57 56 PM

@kevkevinpal
Copy link
Contributor

looks good to me if you can resolve the merge conflict

@kevkevinpal
Copy link
Contributor

kevkevinpal commented Jan 12, 2024

@gouravmpk you can fix the merge conflict with git rebase origin/master and then solve the conflicts there, just make sure you do git fetch -a origin first

@elraphty
Copy link
Contributor

The tests are not passing @gouravmpk

@gouravmpk
Copy link
Contributor Author

Looking into it

@ecurrencyhodler
Copy link
Contributor

You've still got prettier and jest tests failing.

@gouravmpk
Copy link
Contributor Author

gouravmpk commented Jan 16, 2024

You've still got prettier and jest tests failing.

Yeah its not rendering in existing test because the button shows only when user is ORG admin or hasAccess
trying to figure it out
When Jest is passed I can fix prettier no issues there

@ecurrencyhodler
Copy link
Contributor

Jest is still failing and I see a conflicting file:

frontend/app/src/people/widgetViews/summaries/wantedSummaries/tests/CodingBounty.spec.tsx

@gouravmpk
Copy link
Contributor Author

@ecurrencyhodler , I've put in a lot of effort to write the test, but unfortunately, it seems to be facing issues due to conditional rendering. Despite trying every solution I could think of, the problem persists.

@ecurrencyhodler
Copy link
Contributor

Hey thanks for the update. Let me sync with raph.

@ecurrencyhodler
Copy link
Contributor

@gouravmpk we are going to close this PR and I will pay you out for the bounty. We are going to handle this separately in a different issue. Thanks for your attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants