Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞Fix: Organisation Image being displayed as Profile Image for Paid Bounties #1141

Merged
merged 3 commits into from
Dec 19, 2023
Merged

🐞Fix: Organisation Image being displayed as Profile Image for Paid Bounties #1141

merged 3 commits into from
Dec 19, 2023

Conversation

VividhPandey003
Copy link
Contributor

Describe your changes

fixed imageissue

Issue ticket number and link

Fixes #1082

Type of change

Bug Fix

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@ecurrencyhodler
Copy link
Contributor

Nice! LGTM. Let's get a code review.

Copy link
Contributor

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good just would like the comment to describe exactly why its there rather than linking out somewhere else since that might not be true in the future and it causes more effort to figure out whats happening in the code

@@ -50,7 +50,7 @@ const PaidBounty = (props: PaidBountiesProps) => {
title={props.title}
codingLanguage={props.codingLanguage}
isPaid={true}
org_img={props.img}
org_img={props.org_img} //added to fix 1082
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding a comment referencing a github issue since we cant control if github deletes issues incase we need to move to a different platform like gitlab could you change this to something like

org_img={props.org_img} //This sets the organization image in bounty

if you could do that for the other comments aswell

@VividhPandey003
Copy link
Contributor Author

VividhPandey003 commented Dec 19, 2023

@kevkevinpal do we need the comments for org_img? Adding comments to an obvious thing would rather increase the competition. I'd suggest that I shall delete the previous comments. What is your take on it?

@kevkevinpal
Copy link
Contributor

@kevkevinpal do we need the comments for org_img? Adding comments to an obvious thing would rather increase the competition. I'd suggest that I shall delete the previous comments. What is your take on it?

ya I'm fine if the comment isn't there aswell since it should be pretty straight forward

@VividhPandey003
Copy link
Contributor Author

@kevkevinpal do we need the comments for org_img? Adding comments to an obvious thing would rather increase the competition. I'd suggest that I shall delete the previous comments. What is your take on it?

ya I'm fine if the comment isn't there aswell since it should be pretty straight forward

okay then, I'll remove the comments

Signed-off-by: Vividh Pandey <[email protected]>
@kevkevinpal kevkevinpal merged commit 74a59f6 into stakwork:master Dec 19, 2023
6 checks passed
@ecurrencyhodler
Copy link
Contributor

Tested on staging and looks great. Will pay you out as soon as I replenish the funds.

@VividhPandey003 VividhPandey003 deleted the imagecorrect branch December 20, 2023 12:52
elraphty pushed a commit that referenced this pull request Jan 26, 2024
…unties (#1141)

* Fixed Org image being displayed in Profile- Paid Bounties

Signed-off-by: Vividh Pandey <[email protected]>

* Fixed image correction

Signed-off-by: Vividh Pandey <[email protected]>

---------

Signed-off-by: Vividh Pandey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paid bounties show org image, not profile image.
3 participants