-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞Fix: Organisation Image being displayed as Profile Image for Paid Bounties #1141
Conversation
Signed-off-by: Vividh Pandey <[email protected]>
Nice! LGTM. Let's get a code review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good just would like the comment to describe exactly why its there rather than linking out somewhere else since that might not be true in the future and it causes more effort to figure out whats happening in the code
@@ -50,7 +50,7 @@ const PaidBounty = (props: PaidBountiesProps) => { | |||
title={props.title} | |||
codingLanguage={props.codingLanguage} | |||
isPaid={true} | |||
org_img={props.img} | |||
org_img={props.org_img} //added to fix 1082 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of adding a comment referencing a github issue since we cant control if github deletes issues incase we need to move to a different platform like gitlab could you change this to something like
org_img={props.org_img} //This sets the organization image in bounty
if you could do that for the other comments aswell
@kevkevinpal do we need the comments for org_img? Adding comments to an obvious thing would rather increase the competition. I'd suggest that I shall delete the previous comments. What is your take on it? |
ya I'm fine if the comment isn't there aswell since it should be pretty straight forward |
okay then, I'll remove the comments |
Signed-off-by: Vividh Pandey <[email protected]>
Tested on staging and looks great. Will pay you out as soon as I replenish the funds. |
…unties (#1141) * Fixed Org image being displayed in Profile- Paid Bounties Signed-off-by: Vividh Pandey <[email protected]> * Fixed image correction Signed-off-by: Vividh Pandey <[email protected]> --------- Signed-off-by: Vividh Pandey <[email protected]>
Describe your changes
Issue ticket number and link
Fixes #1082
Type of change
Bug Fix
Please delete options that are not relevant.
Checklist before requesting a review