Fix glitch when moving from a tab on profile to default profile view

[Khaalid-oh]

Describe your changes

Issue ticket number and link

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist before requesting a review

• I have performed a self-review of my code
• I have tested on Chrome and Firefox
• I have tested on a mobile device
• I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

Screen.Recording.2023-12-16.at.15.37.30.mov

[ecurrencyhodler]

Hey @Khaalid-oh . The video recording looks like the glitch is still there. Can you take another look?

[Khaalid-oh]

Hey @Khaalid-oh . The video recording looks like the glitch is still there. Can you take another look?

The glitch you are reffering to is not the peopleList that pops out for a while on the user profile?

[ecurrencyhodler]

Actually you're right. I looked at the behavior of other tabs and they display a similar loading behavior before displaying the info.

Have you tested clicking on all the tabs to make sure nothing is broken?

And can you test looking at a profile that isn't yours so that the people list DOES appear both from a signed in and signed out perspective?

[Khaalid-oh]

Actually you're right. I looked at the behavior of other tabs and they display a similar loading behavior before displaying the info.

Have you tested clicking on all the tabs to make sure nothing is broken?

And can you test looking at a profile that isn't yours so that the people list DOES appear both from a signed in and signed out perspective?

Yes, I've done that. I'll send a video testing all that as well

[Khaalid-oh]

Actually you're right. I looked at the behavior of other tabs and they display a similar loading behavior before displaying the info.
Have you tested clicking on all the tabs to make sure nothing is broken?
And can you test looking at a profile that isn't yours so that the people list DOES appear both from a signed in and signed out perspective?

Yes, I've done that. I'll send a video testing all that as well

TRT3.mp4

[ecurrencyhodler]

Perfect ty. Let's get a code review.

[kevkevinpal]

@Khaalid-oh did you make any changes?

[kevkevinpal]

closing this as I'm seeing no changes committed other than config changes and a yarn.lock update

[Khaalid-oh]

closing this as I'm seeing no changes committed other than config changes and a yarn.lock update

SHA: bb0376c

[Khaalid-oh]

closing this as I'm seeing no changes committed other than config changes and a yarn.lock update

There are changes made to [UserInfoDesktopView]
SHA: bb0376c

[kevkevinpal]

I'm not seeing any changes to UserInfoDesktopView other than spacing changes in bb0376c

[Khaalid-oh]

I'm not seeing any changes to UserInfoDesktopView other than spacing changes in bb0376c

SHA: bb0376c

please check PersonPage.tsx

[kevkevinpal]

I'm not seeing any changes to UserInfoDesktopView other than spacing changes in bb0376c

SHA: bb0376c

please check PersonPage.tsx

swapping two args in an and statement doesn't change the result of the and statement that change does nothing