Removed description Image ,Replit from tags #1059 #1062
Conversation
|
Nice good job. |
|
this just removes the replit tag completly not just when its not shown in the bounty @ecurrencyhodler is that what we want |
|
Ohh okay let me check |
|
@kevkevinpal no we want to keep the replit tag. It should only be displayed if it's selected. |
| @@ -166,7 +166,7 @@ const BountyDescription = (props: BountiesDescriptionProps) => { | |||
| {props.title?.length > 80 ? '...' : ''} | |||
| </EuiText> | |||
| </div> | |||
| {descriptionImage && ( | |||
| {/* {descriptionImage && ( commented out reason-> #1059 | |||
There was a problem hiding this comment.
why are we removing this? @ecurrencyhodler we need this if there is an image in git that we want to show
There was a problem hiding this comment.
@kevkevinpal I think that's what is causing the bounty on the homepage to display that image. We should keep it @gouravmpk . The fix is to prevent the image in the description from being displayed in the bounties home page. It should still be displayed in the bounty itself.
|
I tested it myself and its the regex that is matching when it shouldn't @gouravmpk please fix the regex. Simply commenting out code for a bug is not the right approach for most issues especially if we don't want to remove functionality
|
|
Yes I was reviewing the bounty object in response I'm on it , thanks @kevkevinpal |
|
@kevkevinpal I have changed the regex(please verify) here is the video effa85f2-5ac7-43c0-a555-877125902abe.mp4 |
|
Looks good. Let's get another code review |
|
LGTM. Tested and paying you out. |
Describe your changes
Commented out Replit code ,Removed Image from /bounties page containers only
Issue ticket number and link
#1059
Type of change
UI
Checklist before requesting a review
remove.replit.mp4