Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bounties): implements #1001 cleaning up bounties and adding a or… #1053

Merged

Conversation

dylanbathurst
Copy link
Contributor

@dylanbathurst dylanbathurst commented Dec 6, 2023

…g label

Describe your changes

image

Issue ticket number and link

#1001

Type of change

Mostly a cosmetic change where I fixed some issues with styles and layout and created a new button to the organization behind each bounty.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@dylanbathurst dylanbathurst marked this pull request as ready for review December 7, 2023 06:52
@ecurrencyhodler
Copy link
Contributor

ecurrencyhodler commented Dec 7, 2023

Thanks @dylanbathurst for submitting this PR. One thing I'm concerned about is the image the bounty is calling. The first one has "joe" as the provider and uses the profile image instead of the org image. This makes me wonder if you're calling the right image. The same is true for the bounties platform.

This is the org image associated with stakwork:
Screenshot 2023-12-06 at 11 00 23 PM

@dylanbathurst
Copy link
Contributor Author

Ok let me look around some more. I noticed on this line that it was using props.img for the org_img param which is why i used that but i'll find the right image.

{props.org_uuid && props.name && (
<Link to={`/org/bounties/${props.org_uuid}`} target="_blank">
<OrganizationWrap>
<img
Copy link
Contributor

@ecurrencyhodler ecurrencyhodler Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see prop.img used in two ways:

img={props.image}
org_img={props.img}

I think the code used img instead of org_img here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ecurrencyhodler I figured out how to fetch the org details and get the proper org image, now it shows up correctly.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. LGTM. Thanks Dylan.

@kevkevinpal
Copy link
Contributor

So I found an issue where if a user isn't signed in then the pictures don't load in, I think this line is the culprit https://github.com/stakwork/sphinx-tribes/blob/master/frontend/app/src/store/main.ts#L1798

but I think the code looks good and we can merge it @ecurrencyhodler just FYI I will open an issue for this

@kevkevinpal kevkevinpal merged commit 46b4184 into stakwork:master Dec 8, 2023
elraphty pushed a commit that referenced this pull request Jan 26, 2024
#1053)

* feat(bounties): implements #1001 cleaning up bounties and adding a org label

* fix(mobile): adding bottom border to mobile version of the bounty container

* fix(prettier): run prettier script

* fix(bounty): make sure org link uses the org image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants