-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bounties): implements #1001 cleaning up bounties and adding a or… #1053
feat(bounties): implements #1001 cleaning up bounties and adding a or… #1053
Conversation
Thanks @dylanbathurst for submitting this PR. One thing I'm concerned about is the image the bounty is calling. The first one has "joe" as the provider and uses the profile image instead of the org image. This makes me wonder if you're calling the right image. The same is true for the bounties platform. |
Ok let me look around some more. I noticed on this line that it was using |
{props.org_uuid && props.name && ( | ||
<Link to={`/org/bounties/${props.org_uuid}`} target="_blank"> | ||
<OrganizationWrap> | ||
<img |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see prop.img used in two ways:
img={props.image}
org_img={props.img}
I think the code used img instead of org_img here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ecurrencyhodler I figured out how to fetch the org details and get the proper org image, now it shows up correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful. LGTM. Thanks Dylan.
So I found an issue where if a user isn't signed in then the pictures don't load in, I think this line is the culprit https://github.com/stakwork/sphinx-tribes/blob/master/frontend/app/src/store/main.ts#L1798 but I think the code looks good and we can merge it @ecurrencyhodler just FYI I will open an issue for this |
…g label
Describe your changes
Issue ticket number and link
#1001
Type of change
Mostly a cosmetic change where I fixed some issues with styles and layout and created a new button to the organization behind each bounty.
Please delete options that are not relevant.
Checklist before requesting a review