Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented The frontend for superadmin #1051

Closed
wants to merge 0 commits into from
Closed

Implemented The frontend for superadmin #1051

wants to merge 0 commits into from

Conversation

Vayras
Copy link
Contributor

@Vayras Vayras commented Dec 6, 2023

frontend for superadmin
runs on route /superadmin
sphinx superadmin

@ecurrencyhodler
Copy link
Contributor

Hey Vayras! Thanks for submitting the PR. Based on your screenshot, it looks like it's not pixel perfect. You can use dev mode inside of figma to find the exact requirements.

Examples include:

  • #'s aren't centered under "# of DTGP" column
  • Font looks wrong, especiall ony sign out and export CSV

Also pagination should not be visible if there are no bounties to be viewed.

@ecurrencyhodler
Copy link
Contributor

ecurrencyhodler commented Dec 6, 2023

Here's the figma file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this change

@Vayras
Copy link
Contributor Author

Vayras commented Dec 7, 2023

Sure will fix and implement these changes

@Vayras
Copy link
Contributor Author

Vayras commented Dec 7, 2023

@ecurrencyhodler , I have made some changes also the table pagination works fine with mock bounties data
a
let me know what you think

@ecurrencyhodler
Copy link
Contributor

Thanks @Vayras there are still a lot of inconsistencies that I'm seeing. For example the arrow next to 7days isn't spaced correctly and the status on the bounties are not capitalized. Please thoroughly review the figma and make sure everything matches.

@Vayras
Copy link
Contributor Author

Vayras commented Dec 7, 2023

@ecurrencyhodler Can you maybe list some changes that you see that you think really needs to be fixed? That would be a great help thanks.

@kevkevinpal
Copy link
Contributor

I'm seeing the eslint check and prettier check failing

@ecurrencyhodler
Copy link
Contributor

@kevkevinpal let's hold off on merging this until we get the design right as well.

package.json Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
sphinx-tribes.exe Outdated Show resolved Hide resolved
@Vayras
Copy link
Contributor Author

Vayras commented Dec 9, 2023

@ecurrencyhodler how About this? let me know what you think so I can raise the PR
WorkDone

@ecurrencyhodler
Copy link
Contributor

Amazing work vayras! Thank you so much for your attention to detail. I have a few items that I noticed which should be quick fixes.

Can we change:

  • Satoshies -> Satoshis
  • Capitalize: Bounties assigned -> Bounties Assigned
  • Capitalize: OPEN, PAID, ASSIGNED
  • Add "..." to the names in the bounty section if it exceed a certain length.
  • "Bounties Paid" (next to 100%) -> Completed

@ecurrencyhodler
Copy link
Contributor

Also can you address the eslint and prettier issues?

@Vayras
Copy link
Contributor Author

Vayras commented Dec 10, 2023

I have added the commit , I might have tagged the wrong issue number , apologies for that , I have made all the necessary changes , ran prettier and eslint aswell, let me know the update on this , thanks

@ecurrencyhodler
Copy link
Contributor

@Vayras can you do one more screenshot of your updates? Then we can do one more code review.

@Vayras
Copy link
Contributor Author

Vayras commented Dec 11, 2023

@Vayras can you do one more screenshot of your updates? Then we can do one more code review.

Yeah sure

@Vayras
Copy link
Contributor Author

Vayras commented Dec 11, 2023

Screenshot 2023-12-11 232940

@Vayras
Copy link
Contributor Author

Vayras commented Dec 11, 2023

@ecurrencyhodler here's the screenshot , for the issue , for now I have centered the whole thing for a better user experience on ultrawide monitors , let me know your perspective.

@ecurrencyhodler
Copy link
Contributor

@Vayras what text font are you using?

And are the status font bold or not bold?

@ecurrencyhodler
Copy link
Contributor

Thanks for addressing my other comments!

@Vayras
Copy link
Contributor Author

Vayras commented Dec 11, 2023

@Vayras what text font are you using?

And are the status font bold or not bold?

Barlow , same as the figma file , status font is set to bold

@Vayras
Copy link
Contributor Author

Vayras commented Dec 11, 2023

Thanks for addressing my other comments!

You're welcome, let me know if there's an update for me , or if you want any changes

@ecurrencyhodler
Copy link
Contributor

Okay for some reason it doesn't look the same as the figma.

But let's go ahead with a code review @kevkevinpal or @elraphty

@kevkevinpal
Copy link
Contributor

had issues updating accidentally closed so its reopened here sorry for any inconvenience

#1080

kevkevinpal added a commit that referenced this pull request Dec 18, 2023
* fix(#1015): implemented the frontend for superadmin

* fix(#1015): implemented the frontend for superadmin

* Implemented The frontend for superadmin #1051

* implemented the frontend for superadmin #1050

* changes for Varays master #1080

* fix for failing test #1080

* fixed routes

* Capitalized File name and removed auth folder

* moved headerstyles -> HeaderStyles

* prettier

* minor fixes

* modified format and am showing header on super admin page

* remove yarn.lock on top level

---------

Co-authored-by: kevkevin <[email protected]>
elraphty pushed a commit that referenced this pull request Jan 26, 2024
* fix(#1015): implemented the frontend for superadmin

* fix(#1015): implemented the frontend for superadmin

* Implemented The frontend for superadmin #1051

* implemented the frontend for superadmin #1050

* changes for Varays master #1080

* fix for failing test #1080

* fixed routes

* Capitalized File name and removed auth folder

* moved headerstyles -> HeaderStyles

* prettier

* minor fixes

* modified format and am showing header on super admin page

* remove yarn.lock on top level

---------

Co-authored-by: kevkevin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants