-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented The frontend for superadmin #1051
Conversation
Hey Vayras! Thanks for submitting the PR. Based on your screenshot, it looks like it's not pixel perfect. You can use dev mode inside of figma to find the exact requirements. Examples include:
Also pagination should not be visible if there are no bounties to be viewed. |
Here's the figma file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this change
frontend/app/src/config/host.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this change
Sure will fix and implement these changes |
@ecurrencyhodler , I have made some changes also the table pagination works fine with mock bounties data |
Thanks @Vayras there are still a lot of inconsistencies that I'm seeing. For example the arrow next to 7days isn't spaced correctly and the status on the bounties are not capitalized. Please thoroughly review the figma and make sure everything matches. |
@ecurrencyhodler Can you maybe list some changes that you see that you think really needs to be fixed? That would be a great help thanks. |
I'm seeing the eslint check and prettier check failing |
@kevkevinpal let's hold off on merging this until we get the design right as well. |
@ecurrencyhodler how About this? let me know what you think so I can raise the PR |
Amazing work vayras! Thank you so much for your attention to detail. I have a few items that I noticed which should be quick fixes. Can we change:
|
Also can you address the eslint and prettier issues? |
I have added the commit , I might have tagged the wrong issue number , apologies for that , I have made all the necessary changes , ran prettier and eslint aswell, let me know the update on this , thanks |
@Vayras can you do one more screenshot of your updates? Then we can do one more code review. |
Yeah sure |
@ecurrencyhodler here's the screenshot , for the issue , for now I have centered the whole thing for a better user experience on ultrawide monitors , let me know your perspective. |
@Vayras what text font are you using? And are the status font bold or not bold? |
Thanks for addressing my other comments! |
Barlow , same as the figma file , status font is set to bold |
You're welcome, let me know if there's an update for me , or if you want any changes |
Okay for some reason it doesn't look the same as the figma. But let's go ahead with a code review @kevkevinpal or @elraphty |
had issues updating accidentally closed so its reopened here sorry for any inconvenience |
* fix(#1015): implemented the frontend for superadmin * fix(#1015): implemented the frontend for superadmin * Implemented The frontend for superadmin #1051 * implemented the frontend for superadmin #1050 * changes for Varays master #1080 * fix for failing test #1080 * fixed routes * Capitalized File name and removed auth folder * moved headerstyles -> HeaderStyles * prettier * minor fixes * modified format and am showing header on super admin page * remove yarn.lock on top level --------- Co-authored-by: kevkevin <[email protected]>
* fix(#1015): implemented the frontend for superadmin * fix(#1015): implemented the frontend for superadmin * Implemented The frontend for superadmin #1051 * implemented the frontend for superadmin #1050 * changes for Varays master #1080 * fix for failing test #1080 * fixed routes * Capitalized File name and removed auth folder * moved headerstyles -> HeaderStyles * prettier * minor fixes * modified format and am showing header on super admin page * remove yarn.lock on top level --------- Co-authored-by: kevkevin <[email protected]>
frontend for superadmin
runs on route /superadmin