Bounty Creation Unit Test #1037

Khaalid-oh · 2023-12-02T00:43:13Z

Describe your changes

Issue ticket number and link

Closes #996

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist before requesting a review

I have performed a self-review of my code

I have tested on Chrome and Firefox
I have tested on a mobile device
I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

kevkevinpal · 2023-12-08T17:09:23Z

looks like gitactions checks are failing if you can fix

ecurrencyhodler · 2023-12-08T17:10:19Z

Hey @Khaalid-oh thanks for this PR. It looks like some tests are failing such as prettier, craco, and jest. Can you address those? If you're not familiar with how, you can join our stand up and you cask raph/kev for help.

Khaalid-oh · 2023-12-08T22:33:50Z

Hey @Khaalid-oh thanks for this PR. It looks like some tests are failing such as prettier, craco, and jest. Can you address those? If you're not familiar with how, you can join our stand up and you cask raph/kev for help.

Alright, I'm sure he can help with some of the questions I have. You can set that up

ecurrencyhodler · 2023-12-08T22:41:24Z

Invited

kevkevinpal · 2023-12-12T20:05:23Z

made some updates in 0293310

I think we still need to add some changes but I got started a bit but we still probably need to make some changes let me know what you think @Khaalid-oh

…rk done

Khaalid-oh · 2023-12-13T07:45:52Z

made some updates in 0293310

I think we still need to add some changes but I got started a bit but we still probably need to make some changes let me know what you think @Khaalid-oh

Looks nice to me, what other changes do you have in mind?

ecurrencyhodler · 2023-12-13T17:05:53Z

Hey so we are missing two tests from the issue:

Get people bounty test
Delete bounty

Khaalid-oh · 2023-12-13T17:34:58Z

Hey so we are missing two tests from the issue:

Get people bounty test

Delete bounty

Done ✅

ecurrencyhodler · 2023-12-14T16:16:56Z

All tests passed. Let's get one more code review

kevkevinpal · 2023-12-18T16:02:38Z

frontend/app/src/config/host.ts

@@ -3,7 +3,7 @@ const externalDockerHosts = ['localhost:23007', 'localhost:23000'];

 export function getHost(): string {
  const host = window.location.host.includes('localhost') ? 'localhost:5002' : window.location.host;
-  return host;
+  return 'people.sphinx.chat';


please change this back, this will also effect the unit tests

This is also for another issue, I'll create a different PR for it

kevkevinpal · 2023-12-18T16:03:28Z

frontend/app/src/pages/people/PersonPage.tsx

not sure why there is code change for a unit test PR

kevkevinpal · 2023-12-18T16:04:11Z

frontend/app/yarn.lock

we shouldnt be including a new yarn.lock file

kevkevinpal · 2023-12-18T16:04:29Z

frontend/app/src/store/main.ts

@@ -1428,6 +1428,7 @@ export class MainStore {

  async deleteBounty(created: number, owner_pubkey: string): Promise<void> {
    const info = uiStore.meInfo as any;
+    console.log(uiStore.meInfo);


remove console.log I think I may have added this on accident

frontend/app/src/people/widgetViews/organization/AddUserModal.tsx

kevkevinpal · 2023-12-18T16:05:17Z

frontend/app/src/people/userInfo/UserInfoDesktopView.tsx

Revert this, there should be no changes on a unit test PR

This is for another issue raised, I'll create a new PR for this

kevkevinpal · 2023-12-18T16:06:42Z

frontend/app/src/bounties/__tests__/bountyTest.spec.ts

+// jest.mock('../store/main.ts', () => ({
+//   get: jest.fn().mockResolvedValue([
+//       {
+//         body: {
+//           assigned_hours: 0,
+//           assignee: '',
+//           award: '',
+//           bounty_expires: '',
+//           coding_languages: ['Lightning'],
+//           commitment_fee: 0,
+//           created: 1702398254,
+//           deliverables: 'test',
+//           description: 'test',
+//           estimated_completion_date: '',
+//           estimated_session_length: '',
+//           github_description: false,
+//           id: 892,
+//           one_sentence_summary: '',
+//           org_uuid: 'ck13rgua5fdkhph1po4g',
+//           owner_id: '03bfe6723c06fb2b7546df1e8ca1a17ae5c504615da32c945425ccbe8d3ca6260d',
+//           paid: false,
+//           paid_date: null,
+//           price: '1',
+//           show: true,
+//           ticket_url: '',
+//           title: 'test',
+//           tribe: 'None',
+//           type: 'freelance_job_request',
+//           updated: '2023-12-12T16:24:14.585187Z',
+//           wanted_type: 'Mobile development'
+//         },
+//         organization: {
+//           img: 'https://memes.sphinx.chat/public/l-_K9mJatGvz16Ixw1lPHtG9Om8QWtZtiRS_aIQme9c=',
+//           name: 'test after jwt',
+//           uuid: 'ck13rgua5fdkhph1po4g'
+//         },
+//         person: {
+//           created: '2021-11-15T19:09:46.356248Z',
+//           deleted: false,
+//           description: 'This is the real kevkevin I like to code alot',
+//           extras: null,
+//           github_issues: null,
+//           id: 38,
+//           img: 'https://memes.sphinx.chat/public/1jPjjDsrwRoBPzahpWjR8QE5DjQ726MsUSrCOjflSmo=',
+//           last_login: 1702065128,
+//           new_ticket_time: 0,
+//           owner_alias: 'kevkevin',
+//           owner_contact_key:
+//             'MIIBCgKCAQEAxtkwpxx8RjdVhgzx4oUYkmJQttvFzwI+lCWYgngMi/4o8OgUF9eVvW8zSY0t9A1KEY2MdEOTGjv9QiesoN7hmkgTdUqDQd1LIsU4vBtwPVWyJs0d6VEdMySN9veN68S7Fu+S20e5gygj17X8cffoEwLNDPi0dsTgojAC/uggE98zJvHmEd/Ob/W3ADQD68DQErCejvqXK2557GtsDNo35iIN9KlOPLRmvG3S/oV4pIyj5Z/6uMEXlok2b/mtvP0E4ClMP77j9QPs7mQarQ03XM0iRC2Ru/Qg/xWBTeqmYv5zfD8hmtzakBVyMSrHNZKZjSnURVNVpFaEXoB4wBqcvQIDAQAB',
+//           owner_pubkey: '',
+//           owner_route_hint: '',
+//           price_to_meet: 21,
+//           tags: [],
+//           twitter_confirmed: true,
+//           unique_name: 'umbreltest',
+//           unlisted: false,
+//           updated: '2023-12-04T19:48:05.641056Z',
+//           uuid: 'cd9dm5ua5fdtsj2c2nbg',
+//           wanteds: []
+//         }
+//       }
+//     ]),
+// }));


we should delete this comment

kevkevinpal · 2023-12-18T16:06:47Z

frontend/app/src/bounties/__tests__/bountyTest.spec.ts

+// }));
+
+const mockedApi = api as jest.Mocked<typeof api>;
+//const mockedUiStore = uiStore as jest.Mocked<typeof uiStore>;


delete comment

kevkevinpal · 2023-12-18T16:06:52Z

frontend/app/src/bounties/__tests__/bountyTest.spec.ts

+  beforeEach(() => {
+    window.localStorage.clear();
+
+    //window.localStorage.setItem('peopleBounties', JSON.stringify(mockBounties));


delete comment

kevkevinpal · 2023-12-18T16:07:00Z

frontend/app/src/bounties/__tests__/bountyTest.spec.ts

+  //it('should save and retrieve bounties from local storage', () => {
+  //  const storedBounties = JSON.parse(window.localStorage.getItem('peopleBounties') || '[]');
+  //  expect(storedBounties).toEqual(mockBounties);
+  //}, 8000);


delete comment

kevkevinpal · 2023-12-18T16:07:08Z

frontend/app/src/bounties/__tests__/bountyTest.spec.ts

+  });
+
+  it('should save a new bounty and persist to localStorage', async () => {
+    //mockedApi.post.mockResolvedValue({ data: newBounty });


delete comment

kevkevinpal · 2023-12-18T16:07:15Z

frontend/app/src/bounties/__tests__/bountyTest.spec.ts

+    //const bounties = JSON.parse(mockLocalStorage.getItem('peopleBounties'));
+    //expect(window.localStorage.getItem('peopleBounties')).toContainEqual([]);


delete comment

kevkevinpal · 2023-12-18T16:07:45Z

frontend/app/src/bounties/__tests__/bountyTest.spec.ts

+    const expectedBountyResponse = [
+      {
+        body: {
+          assigned_hours: 0,
+          assignee: '',
+          award: '',
+          bounty_expires: '',
+          coding_languages: ['Lightning'],
+          commitment_fee: 0,
+          created: 1702398254,
+          deliverables: 'test',
+          description: 'test',
+          estimated_completion_date: '',
+          estimated_session_length: '',
+          github_description: false,
+          id: 892,
+          one_sentence_summary: '',
+          org_uuid: 'ck13rgua5fdkhph1po4g',
+          owner_id: '03bfe6723c06fb2b7546df1e8ca1a17ae5c504615da32c945425ccbe8d3ca6260d',
+          paid: false,
+          paid_date: null,
+          price: '1',
+          show: true,
+          ticket_url: '',
+          title: 'test',
+          tribe: 'None',
+          type: 'freelance_job_request',
+          updated: '2023-12-12T16:24:14.585187Z',
+          wanted_type: 'Mobile development'
+        },
+        organization: {
+          img: 'https://memes.sphinx.chat/public/l-_K9mJatGvz16Ixw1lPHtG9Om8QWtZtiRS_aIQme9c=',
+          name: 'test after jwt',
+          uuid: 'ck13rgua5fdkhph1po4g'
+        },
+        person: {
+          created: '2021-11-15T19:09:46.356248Z',
+          deleted: false,
+          description: 'This is the real kevkevin I like to code alot',
+          extras: null,
+          github_issues: null,
+          id: 38,
+          img: 'https://memes.sphinx.chat/public/1jPjjDsrwRoBPzahpWjR8QE5DjQ726MsUSrCOjflSmo=',
+          last_login: 1702065128,
+          new_ticket_time: 0,
+          owner_alias: 'kevkevin',
+          owner_contact_key:
+            'MIIBCgKCAQEAxtkwpxx8RjdVhgzx4oUYkmJQttvFzwI+lCWYgngMi/4o8OgUF9eVvW8zSY0t9A1KEY2MdEOTGjv9QiesoN7hmkgTdUqDQd1LIsU4vBtwPVWyJs0d6VEdMySN9veN68S7Fu+S20e5gygj17X8cffoEwLNDPi0dsTgojAC/uggE98zJvHmEd/Ob/W3ADQD68DQErCejvqXK2557GtsDNo35iIN9KlOPLRmvG3S/oV4pIyj5Z/6uMEXlok2b/mtvP0E4ClMP77j9QPs7mQarQ03XM0iRC2Ru/Qg/xWBTeqmYv5zfD8hmtzakBVyMSrHNZKZjSnURVNVpFaEXoB4wBqcvQIDAQAB',
+          owner_pubkey: '',
+          owner_route_hint: '',
+          price_to_meet: 21,
+          tags: [],
+          twitter_confirmed: true,
+          unique_name: 'umbreltest',
+          unlisted: false,
+          updated: '2023-12-04T19:48:05.641056Z',
+          uuid: 'cd9dm5ua5fdtsj2c2nbg',
+          wanteds: []
+        }
+      }
+    ];


we should move this into the mockBounties.data.ts file

frontend/app/yarn.lock

frontend/app/src/people/userInfo/UserInfoDesktopView.tsx

kevkevinpal · 2023-12-18T21:10:06Z

frontend/app/src/pages/people/PersonPage.tsx

why is this file modifed

This is for the [glitch when moving from a tab on profile to default profile view]

it should not be modified in this PR

…to saif

Khaalid-oh and others added 9 commits November 28, 2023 03:42

feat: add user

4569708

Merge branch 'stakwork:master' into master

a322d8f

fix: add user to select button

e3d0550

fix: add user to select button RESET

f830b05

fix: add user to select button RESET

f97407b

fix: add user to select button RESET

66b61af

fix: removed yarn.lock diff

87cb87e

test: bounty creation test

c9b862f

test: Bounty Tests

23a520a

Merge remote-tracking branch 'origin/master' into saif

4940d1b

kevkevinpal added some changes to make tests pass still needs some wo…

0293310

…rk done

Khaalid-oh added 2 commits December 14, 2023 10:09

test:Bounty Creation Unit Test

b843871

test:Bounty Creation Unit Test

03cd472

Khaalid-oh mentioned this pull request Dec 15, 2023

[Bounty Creation Unit Test] Create mock data for bounty creation #996

Closed

Khaalid-oh and others added 7 commits December 16, 2023 15:55

fix: glitch when moving from a tab on profile to default profile view

49057ef

fix: glitch when moving from a tab on profile to default profile view

bb0376c

feat: Add new User Width

d03b594

test: add user modal

73fbec2

Merge branch 'stakwork:master' into saif

2882777

test: add user modal width

75245c8

test: add user modal width

3c4b3d9

kevkevinpal reviewed Dec 18, 2023

View reviewed changes

frontend/app/src/pages/people/PersonPage.tsx Outdated

Copy link

Contributor

kevkevinpal Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why there is code change for a unit test PR

kevkevinpal reviewed Dec 18, 2023

View reviewed changes

frontend/app/yarn.lock Outdated

Copy link

Contributor

kevkevinpal Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldnt be including a new yarn.lock file

kevkevinpal reviewed Dec 18, 2023

View reviewed changes

frontend/app/src/people/widgetViews/organization/AddUserModal.tsx Outdated Show resolved Hide resolved

kevkevinpal reviewed Dec 18, 2023

View reviewed changes

Khaalid-oh and others added 5 commits December 18, 2023 18:54

Merge branch 'stakwork:master' into saif

93e50eb

test: bounty test update

d22b8e7

Merge branch 'master' into saif

6c9ed99

test: bounty test update

bf39e60

test: bounty test update

4da6476

kevkevinpal reviewed Dec 18, 2023

View reviewed changes

frontend/app/yarn.lock Outdated Show resolved Hide resolved

kevkevinpal reviewed Dec 18, 2023

View reviewed changes

frontend/app/src/people/userInfo/UserInfoDesktopView.tsx Outdated Show resolved Hide resolved

kevkevinpal reviewed Dec 18, 2023

View reviewed changes

Khaalid-oh and others added 4 commits December 19, 2023 10:31

bounty test PR refactored

d11bc80

Merge branch 'master' into saif

51b1abb

Merge branch 'saif' of https://github.com/Khaalid-oh/sphinx-tribes in…

01a5bbf

…to saif

cleanup

257c947

Khaalid-oh closed this Dec 20, 2023

Khaalid-oh deleted the saif branch December 20, 2023 16:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bounty Creation Unit Test #1037

Bounty Creation Unit Test #1037

Khaalid-oh commented Dec 2, 2023 •

edited

Loading

kevkevinpal commented Dec 8, 2023

ecurrencyhodler commented Dec 8, 2023

Khaalid-oh commented Dec 8, 2023

ecurrencyhodler commented Dec 8, 2023

kevkevinpal commented Dec 12, 2023 •

edited

Loading

Khaalid-oh commented Dec 13, 2023

ecurrencyhodler commented Dec 13, 2023

Khaalid-oh commented Dec 13, 2023 •

edited

Loading

ecurrencyhodler commented Dec 14, 2023

kevkevinpal Dec 18, 2023

Khaalid-oh Dec 18, 2023

kevkevinpal Dec 18, 2023

kevkevinpal Dec 18, 2023

kevkevinpal Dec 18, 2023

kevkevinpal Dec 18, 2023

Khaalid-oh Dec 18, 2023

kevkevinpal Dec 18, 2023

kevkevinpal Dec 18, 2023

kevkevinpal Dec 18, 2023

kevkevinpal Dec 18, 2023

kevkevinpal Dec 18, 2023

kevkevinpal Dec 18, 2023

kevkevinpal Dec 18, 2023

kevkevinpal Dec 18, 2023

Khaalid-oh Dec 18, 2023

kevkevinpal Dec 19, 2023

		//const bounties = JSON.parse(mockLocalStorage.getItem('peopleBounties'));
		//expect(window.localStorage.getItem('peopleBounties')).toContainEqual([]);

Bounty Creation Unit Test #1037

Bounty Creation Unit Test #1037

Conversation

Khaalid-oh commented Dec 2, 2023 • edited Loading

Describe your changes

Issue ticket number and link

Type of change

Checklist before requesting a review

kevkevinpal commented Dec 8, 2023

ecurrencyhodler commented Dec 8, 2023

Khaalid-oh commented Dec 8, 2023

ecurrencyhodler commented Dec 8, 2023

kevkevinpal commented Dec 12, 2023 • edited Loading

Khaalid-oh commented Dec 13, 2023

ecurrencyhodler commented Dec 13, 2023

Khaalid-oh commented Dec 13, 2023 • edited Loading

ecurrencyhodler commented Dec 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Khaalid-oh commented Dec 2, 2023 •

edited

Loading

kevkevinpal commented Dec 12, 2023 •

edited

Loading

Khaalid-oh commented Dec 13, 2023 •

edited

Loading