🐛 Fix: Bad UI Issues in Profile Section #1025

VividhPandey003 · 2023-11-29T20:13:25Z

Describe your changes

Before Changes:

before.changes.mov

After Changes:

after.changes.mov

Issue ticket number and link

Closes #957

Type of change

UI Changes in frontend

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist before requesting a review

I have performed a self-review of my code
I have tested on Chrome and Firefox
I have tested on a mobile device
I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

Signed-off-by: Vividh Pandey <[email protected]>

ecurrencyhodler · 2023-11-29T20:48:24Z

This is great work. Thanks for posting a video. I'll assign a bounty for 300,000 sats for this.

Let's do a code review. Raph or Kev will be able to help you with the test that's failing.

VividhPandey003 · 2023-11-30T03:31:06Z

This is great work. Thanks for posting a video. I'll assign a bounty for 300,000 sats for this.

Let's do a code review. Raph or Kev will be able to help you with the test that's failing.

Sure, Thank You

kevkevinpal · 2023-11-30T15:49:07Z

frontend/app/src/components/form/schema.ts

+  // {
+  //   name: 'repos',
+  //   label: 'Github Repository Links',
+  //   widget: true,
+  //   type: 'creatablemultiselect',
+  //   options: [],
+  //   note: 'Enter in this format: ownerName/repoName, (e.g. stakwork/sphinx-tribes).',
+  //   validator: repoArrayStrValidator, // look for 1 slash
+  //   page: 1
+  // },


@ecurrencyhodler did we want to remove this Github repo links from the profile, if so I think we should delete this instead of commenting it out

I'd feel comfortable merging these changes if this was reverted back to normal

okay sure, I will do the needful. Also regarding the repository links- instead of creatablemultiselect it should be text as creatablemultiselect contains the list of languages.

@kevkevinpal I am somewhat confused with what type the githubRepositoryLinks fields should be. Could you please help me with it

Hey sorry somehow I missed this. Yes let's remove github repo links because we have the github profile.

Well right now I have included the github repo links section with the type as text and validator-commented out.
@ecurrencyhodler @kevkevinpal What is the final version of the about page you guys would want, with the github links section or without it.

There are two categories:
Github profile
Github links for a repo

Keep the github profile section but remove the github links for a repo

Sure, so completely removing it right. And not commenting it

Yeah remove it. Thanks.

Okay, on it. Thanks. I would remove the other dependencies of it as well right which are in aboutview.tsx. Just want to confirm if we are on the same page

also changed the type to text

VividhPandey003 · 2023-11-30T17:24:20Z

@kevkevinpal the latest commit (ec283f5)would not completely fix the problem as the validator would recognize text as not being in the correct format.
Here's what I noticed after implementing current final version

The approach in my head is to remove the validator and keep it as a simple text.

kevkevinpal · 2023-11-30T20:18:08Z

@kevkevinpal the latest commit (ec283f5)would not completely fix the problem as the validator would recognize text as not being in the correct format. Here's what I noticed after implementing current final version

The approach in my head is to remove the validator and keep it as a simple text.

hmm yea I think just commenting or removing the validator part would be good, that is strange

VividhPandey003 · 2023-12-01T18:20:38Z

Closing this PR/ making a new PR instead with less commits/cleaner version.

VividhPandey003 · 2023-12-01T18:26:46Z

@kevkevinpal @ecurrencyhodler @elraphty , I am facing some eslint issues while trying to commit my code. I had made a new branch and was trying to make a commit but I am not able to do it from my local. Looks like we have some unused vars.

Could you please help me with this.

Signed-off-by: Vividh Pandey <[email protected]>

VividhPandey003 · 2023-12-04T17:53:43Z

@kevkevinpal I have made the required prettier changes. Could you please review the code once.
Thanks

ecurrencyhodler · 2023-12-04T18:09:59Z

@VividhPandey003 can you post one more screenshot of what the final UI looks like? Thanks.

VividhPandey003 · 2023-12-04T18:21:21Z

Here @ecurrencyhodler

after.changes.4dec.mov

ecurrencyhodler · 2023-12-04T18:28:55Z

@VividhPandey003 I see a small text/alignment issue with github. Rather than the url, let's just simply display the word "Github".

VividhPandey003 · 2023-12-04T18:30:57Z

@VividhPandey003 I see a small text/alignment issue with github. Rather than the url, let's just simply display the word "Github".

sure so a follow up doubt on this.

the pretext github dot com should not be displayed when the input is not active. i.e when I click to enter my github id then only it should display github dot com / userid

ecurrencyhodler · 2023-12-04T18:32:24Z

Yes that's correct. It doesn't show the url when it is not active. But when I click on the box, the url should appear.

Signed-off-by: Vividh Pandey <[email protected]>

VividhPandey003 · 2023-12-05T11:48:30Z

@ecurrencyhodler . Done with the required changes. My latest commit fixes the github link issue as well

fixed.github.prepend.text.mov

Signed-off-by: Vividh Pandey <[email protected]>

ecurrencyhodler · 2023-12-05T16:21:05Z

Great job. LGTM. Let's get a code review.

ecurrencyhodler · 2023-12-05T21:32:05Z

Tested and it looks great! Paying you out now.

* Removed Github Repository Links Section Signed-off-by: Vividh Pandey <[email protected]> * Fixed overlay of tribes section Signed-off-by: Vividh Pandey <[email protected]> * Fixed: pretext and input text to be on same y-axis Signed-off-by: Vividh Pandey <[email protected]> * Fixed default width of form components Signed-off-by: Vividh Pandey <[email protected]> * Fixed Github Repository Links Area also changed the type to text * Commented Validator temporarily * Update interfaces.ts * Update schema.ts * Update AboutFocusView.tsx * Update AboutView.tsx * Update schema.ts * Prettier ReRun Signed-off-by: Vividh Pandey <[email protected]> * Fixed Prepend Text for text inputs Signed-off-by: Vividh Pandey <[email protected]> * Fixed Prettier Checks Signed-off-by: Vividh Pandey <[email protected]> --------- Signed-off-by: Vividh Pandey <[email protected]>

VividhPandey003 added 4 commits November 30, 2023 01:19

Removed Github Repository Links Section

4fc3876

Signed-off-by: Vividh Pandey <[email protected]>

Fixed overlay of tribes section

f97f993

Signed-off-by: Vividh Pandey <[email protected]>

Fixed: pretext and input text to be on same y-axis

3ca2c1f

Signed-off-by: Vividh Pandey <[email protected]>

Fixed default width of form components

0d97538

Signed-off-by: Vividh Pandey <[email protected]>

VividhPandey003 changed the title ~~🐞Fix: Bad UI Issues in Profile Section~~ Bug Fix: Bad UI Issues in Profile Section Nov 29, 2023

kevkevinpal reviewed Nov 30, 2023

View reviewed changes

Fixed Github Repository Links Area

ec283f5

also changed the type to text

VividhPandey003 added 7 commits December 1, 2023 11:10

Commented Validator temporarily

657dec5

Merge branch 'stakwork:master' into fix-bad-ui

da88664

Update interfaces.ts

58b5661

Update schema.ts

228a6bc

Update AboutFocusView.tsx

263695c

Update AboutView.tsx

7efa779

Update schema.ts

fed78fc

VividhPandey003 and others added 2 commits December 4, 2023 22:59

Merge branch 'stakwork:master' into fix-bad-ui

ef17e7f

Prettier ReRun

732b476

Signed-off-by: Vividh Pandey <[email protected]>

VividhPandey003 changed the title ~~Bug Fix: Bad UI Issues in Profile Section~~ 🐛 Fix: Bad UI Issues in Profile Section Dec 4, 2023

Fixed Prepend Text for text inputs

a3a4b1f

Signed-off-by: Vividh Pandey <[email protected]>

Fixed Prettier Checks

99e49d4

Signed-off-by: Vividh Pandey <[email protected]>

VividhPandey003 requested review from ecurrencyhodler and kevkevinpal December 5, 2023 11:53

kevkevinpal merged commit 12bd3e4 into stakwork:master Dec 5, 2023
5 checks passed

VividhPandey003 deleted the fix-bad-ui branch December 20, 2023 12:48

VividhPandey003 restored the fix-bad-ui branch December 20, 2023 12:49

VividhPandey003 deleted the fix-bad-ui branch December 20, 2023 12:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Fix: Bad UI Issues in Profile Section #1025

🐛 Fix: Bad UI Issues in Profile Section #1025

VividhPandey003 commented Nov 29, 2023 •

edited

Loading

ecurrencyhodler commented Nov 29, 2023

VividhPandey003 commented Nov 30, 2023

kevkevinpal Nov 30, 2023

kevkevinpal Nov 30, 2023

VividhPandey003 Nov 30, 2023 •

edited

Loading

VividhPandey003 Nov 30, 2023

ecurrencyhodler Dec 1, 2023

VividhPandey003 Dec 1, 2023

ecurrencyhodler Dec 1, 2023

VividhPandey003 Dec 1, 2023

ecurrencyhodler Dec 1, 2023

VividhPandey003 Dec 1, 2023 •

edited

Loading

VividhPandey003 commented Nov 30, 2023 •

edited

Loading

kevkevinpal commented Nov 30, 2023

VividhPandey003 commented Dec 1, 2023

VividhPandey003 commented Dec 1, 2023 •

edited

Loading

VividhPandey003 commented Dec 4, 2023

ecurrencyhodler commented Dec 4, 2023

VividhPandey003 commented Dec 4, 2023

ecurrencyhodler commented Dec 4, 2023

VividhPandey003 commented Dec 4, 2023

ecurrencyhodler commented Dec 4, 2023

VividhPandey003 commented Dec 5, 2023

ecurrencyhodler commented Dec 5, 2023

ecurrencyhodler commented Dec 5, 2023

🐛 Fix: Bad UI Issues in Profile Section #1025

🐛 Fix: Bad UI Issues in Profile Section #1025

Conversation

VividhPandey003 commented Nov 29, 2023 • edited Loading

Describe your changes

Issue ticket number and link

Type of change

Checklist before requesting a review

ecurrencyhodler commented Nov 29, 2023

VividhPandey003 commented Nov 30, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VividhPandey003 Nov 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VividhPandey003 Dec 1, 2023 • edited Loading

Choose a reason for hiding this comment

VividhPandey003 commented Nov 30, 2023 • edited Loading

kevkevinpal commented Nov 30, 2023

VividhPandey003 commented Dec 1, 2023

VividhPandey003 commented Dec 1, 2023 • edited Loading

VividhPandey003 commented Dec 4, 2023

ecurrencyhodler commented Dec 4, 2023

VividhPandey003 commented Dec 4, 2023

ecurrencyhodler commented Dec 4, 2023

VividhPandey003 commented Dec 4, 2023

ecurrencyhodler commented Dec 4, 2023

VividhPandey003 commented Dec 5, 2023

ecurrencyhodler commented Dec 5, 2023

ecurrencyhodler commented Dec 5, 2023

VividhPandey003 commented Nov 29, 2023 •

edited

Loading

VividhPandey003 Nov 30, 2023 •

edited

Loading

VividhPandey003 Dec 1, 2023 •

edited

Loading

VividhPandey003 commented Nov 30, 2023 •

edited

Loading

VividhPandey003 commented Dec 1, 2023 •

edited

Loading