Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update frontend title after endpoint #691

Merged
merged 8 commits into from
Dec 14, 2023
Merged

feat: Update frontend title after endpoint #691

merged 8 commits into from
Dec 14, 2023

Conversation

Ekep-Obasi
Copy link
Contributor

Closes: #688

frontend automatically reflects changes when /about the endpoint is updated

Preview

https://www.loom.com/share/fd11909e312f48e99de159a610897984?sid=54002e6e-c417-4ada-820d-c3524fbadba6

search_term: '',
title: '',
}
// const admins = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright

Copy link
Collaborator

@Rassl Rassl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @Ekep-Obasi , I have minor comment, please remove those, everything else looking good

@Ekep-Obasi
Copy link
Contributor Author

Awesome @Ekep-Obasi , I have minor comment, please remove those, everything else looking good

Thanks @Rassl : )

Copy link
Collaborator

@Rassl Rassl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rassl Rassl merged commit d5589c0 into stakwork:master Dec 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update frontend after setting a Title on /about endpoint
2 participants