-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed issue #646 #652
fixed issue #646 #652
Conversation
@kevkevinpal @Rassl We seem to have lost trending topics on the main graph: The screenshot should only appear when |
@@ -76,8 +77,12 @@ export const Trending = ({ onSubmit }: Props) => { | |||
return ( | |||
<Wrapper> | |||
<div> | |||
{trendingTopics.length === 0 && !loading ? ( | |||
{trendingTopics.length !== 0 && !loading ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh looks like this line broke that lemme fix that rn
@kevkevinpal @tomsmith8 Let me know if you need my assistance |
@kevkevinpal Can we check if this PR also changed the /topics response for filtering. Currently when filtering by |
See Loom here: https://www.loom.com/share/7c3bc33a490e4f9fae2681c20d17018b?sid=a8f63c12-a8ea-4f38-8788-ac892c4221ac I do see responses half way down? even though I'm on a different filter |
Issue 2 (what the bounty was for) - When tapping load more, it doesn't stay in place and show the new row below but bounces randomly - ticket #646 |
I guess It happens for the first time when the load more is clicked it jumps randomly and then It work fine the new rows load at the correct location , Let me look for a fix |
@kevkevinpal @Rassl Topic Curation table is broken for edge count, alphabetical and date filters. Can we re-review this PR as I think this was when the issue arose? |
the required fix for this issue has been implmented
closes #646