Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #646 #652

Merged
merged 4 commits into from
Dec 5, 2023
Merged

fixed issue #646 #652

merged 4 commits into from
Dec 5, 2023

Conversation

Vayras
Copy link
Contributor

@Vayras Vayras commented Dec 1, 2023

the required fix for this issue has been implmented

  • Load more doesn't move the list
  • Load more shows the first new row in the same spot where 'Load More' used to be (hide load more and show the new row)

closes #646

@kevkevinpal kevkevinpal merged commit c42a17f into stakwork:master Dec 5, 2023
4 checks passed
@tomsmith8
Copy link
Contributor

@kevkevinpal @Rassl We seem to have lost trending topics on the main graph:
image
The fix for the ticket was to reintroduce the Title and icon as it was previously removed.

The screenshot should only appear when /get_trends returns an empty array

@@ -76,8 +77,12 @@ export const Trending = ({ onSubmit }: Props) => {
return (
<Wrapper>
<div>
{trendingTopics.length === 0 && !loading ? (
{trendingTopics.length !== 0 && !loading ? (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh looks like this line broke that lemme fix that rn

@Vayras
Copy link
Contributor Author

Vayras commented Dec 5, 2023

@kevkevinpal @tomsmith8 Let me know if you need my assistance

@tomsmith8
Copy link
Contributor

@kevkevinpal Can we check if this PR also changed the /topics response for filtering. Currently when filtering by edge_count or 'alphabetically` its displaying the most recent:
Screenshot 2023-12-05 at 19 00 12

@tomsmith8
Copy link
Contributor

tomsmith8 commented Dec 5, 2023

See Loom here: https://www.loom.com/share/7c3bc33a490e4f9fae2681c20d17018b?sid=a8f63c12-a8ea-4f38-8788-ac892c4221ac

I do see responses half way down? even though I'm on a different filter

@tomsmith8
Copy link
Contributor

Issue 2 (what the bounty was for) - When tapping load more, it doesn't stay in place and show the new row below but bounces randomly - ticket #646
See Loom: https://www.loom.com/share/44e98b632fcd48be9913d76988541318?sid=3208fc3e-f49b-4de3-93d5-dff137943f54

@Vayras
Copy link
Contributor Author

Vayras commented Dec 5, 2023

I guess It happens for the first time when the load more is clicked it jumps randomly and then It work fine the new rows load at the correct location , Let me look for a fix

@tomsmith8
Copy link
Contributor

@kevkevinpal @Rassl Topic Curation table is broken for edge count, alphabetical and date filters. Can we re-review this PR as I think this was when the issue arose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve 'Load More' UX
3 participants