Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/auth #606

Closed
wants to merge 11 commits into from
Closed

Feat/auth #606

wants to merge 11 commits into from

Conversation

tobi-bams
Copy link
Collaborator

Try to setup admin authentication

@tomsmith8
Copy link
Contributor

@kevkevinpal There are some trade-offs here. So we're going to keep this PR live but not merge.
Let's have an arch discussion next week for end to end how we want Auth and L402s to work as it requires changes for both

@kevkevinpal
Copy link
Collaborator

looks like there is an error occuring in the new network test where its saying fetch is undefined which is causing the unit tests to fail

@tobi-bams
Copy link
Collaborator Author

looks like there is an error occuring in the new network test where its saying fetch is undefined which is causing the unit tests to fail

Yes, and that's because node 16 does not have fetch in-built with it and jest runs in a node environment, can we please upgrade the node version we are using to run the test???

I guess node 18 and above support fetch

@tobi-bams tobi-bams linked an issue Nov 20, 2023 that may be closed by this pull request
@kevkevinpal
Copy link
Collaborator

looks like there is an error occuring in the new network test where its saying fetch is undefined which is causing the unit tests to fail

Yes, and that's because node 16 does not have fetch in-built with it and jest runs in a node environment, can we please upgrade the node version we are using to run the test???

I guess node 18 and above support fetch

added a new .nvmrc-unit file to use a newer node version

@kevkevinpal
Copy link
Collaborator

ya tests are passing now! 41d9b71

Copy link
Collaborator

@Rassl Rassl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@tobi-bams tobi-bams closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Auth flow for new Boltwall auth layer
4 participants