-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar rework #503
Sidebar rework #503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still need to manually review but code review looks good to me
<TranscriptWrapper grow={1} shrink={1}> | ||
<Transcript node={selectedNode} stateless /> | ||
</TranscriptWrapper> | ||
<div ref={scrollTargetRef} style={{ overflow: 'auto', flex: 1, width: '100%' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can make this a styled component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I wasn't exactly sure what to do with it since it's acting to reset the scroll.
Changes