Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar rework #503

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Sidebar rework #503

merged 8 commits into from
Oct 18, 2023

Conversation

cosmicpotato137
Copy link
Contributor

Changes

  • Refactored audio, video and search results to show the title of the resource instead of the description.
  • Added the description above transcript in the youtube element.
  • Fixed youtube scroll div to reset to the top when selecting a new node

Screenshot 2023-10-17 113549

Screenshot 2023-10-17 113754

Copy link
Collaborator

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need to manually review but code review looks good to me

<TranscriptWrapper grow={1} shrink={1}>
<Transcript node={selectedNode} stateless />
</TranscriptWrapper>
<div ref={scrollTargetRef} style={{ overflow: 'auto', flex: 1, width: '100%' }}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can make this a styled component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I wasn't exactly sure what to do with it since it's acting to reset the scroll.

@kevkevinpal kevkevinpal merged commit c4c41d6 into stakwork:master Oct 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants