Focus on node children #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevkevinpal
reviewed
Oct 16, 2023
Comment on lines
+53
to
+72
| const children: NodeExtended[] = graphData?.nodes.filter((node) => | ||
| selected.children?.find((str) => str === node.id), | ||
| ) | ||
|
|
||
| // position of node | ||
| const spos = new Vector3(selected.x, selected.y, selected.z) | ||
| // average positioon of children | ||
| let avgDir = new Vector3(0, 0, 0) | ||
|
|
||
| children.map((child: NodeExtended) => { | ||
| avgDir = avgDir.add(new Vector3(child.x, child.y, child.z).normalize()) | ||
|
|
||
| return child | ||
| }) | ||
|
|
||
| // offset from node based on children | ||
| const sizeOffset = selected.scale ? 1 - 1 / (selected.scale + 10) : 1 | ||
| const offset = spos.sub(avgDir).multiplyScalar(0.8 * sizeOffset) | ||
|
|
||
| pos = spos.add(offset) |
There was a problem hiding this comment.
this might be good to have as a function that we can test since there is some mathy stuff involved
|
This change is looking good to me going to merge tests are failing but I think thats an issue one our side with our gitactions, I can try and fix that |
|
@kevkevinpal do you still want me to relocate the math to a function? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change rotates the camera so that both the selected text and it's children are in view. May need to tweak how far the camera zooms out since right now it depends on how far the children nodes are from the parent.
Closes #473