fix(search): tapping search icon bug #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rassl
reviewed
Sep 27, 2023
| viewBox="0 0 32 32" | ||
| fill="currentColor" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| onClick={props.onClick} |
There was a problem hiding this comment.
this icons are generated by script, and should not have any event handlers, please remove this prop and add handler to wrapper
There was a problem hiding this comment.
ok, i will make required changes
Rassl
requested changes
Sep 27, 2023
|
@pankaj1980patel I merged this in favor #434 please email me @ [email protected] and we can get you new tasks to work on and send you some sats for the work done on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tapping search icon should initiate search