Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add latitude longitude for add source modal #424

Merged
merged 3 commits into from
Sep 22, 2023
Merged

feat: add latitude longitude for add source modal #424

merged 3 commits into from
Sep 22, 2023

Conversation

Rassl
Copy link
Collaborator

@Rassl Rassl commented Sep 21, 2023 •
edited
Loading

image

@Rassl Rassl requested a review from kevkevinpal September 21, 2023 19:24
kevkevinpal
kevkevinpal approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added comments to remove console.logs but will merge

src/components/AddNodeModal/Location/index.tsx
export const Location: FC<Props> = ({ setValue, latitude, longitude }) => {
const [enableLocation, setEnableLocation] = useState(false)

console.log(latitude)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to remove

src/components/AddNodeModal/Location/index.tsx
const [enableLocation, setEnableLocation] = useState(false)

console.log(latitude)
console.log(longitude)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to remove

@kevkevinpal kevkevinpal merged commit 495b766 into master Sep 22, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevkevinpal kevkevinpal kevkevinpal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rassl @kevkevinpal