Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update transcript logic for improved playback experience #2504

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

KVV94
Copy link
Contributor

@KVV94 KVV94 commented Dec 5, 2024

Ticket №2503

closes #2503

Problem:

The transcript viewer was displaying all lines at once, making it difficult to read and follow along with the video content. The requirement was to implement gradual appearance of lines synchronized with playback.

Solution:

Implemented conditional rendering of transcript lines:

  • Only the first line is shown at start
  • Subsequently, lines appear with a small lead time (5 seconds) relative to current playback time
  • During seek/rewind, only relevant lines are displayed

Changes:

  • Modified Viewer component for conditional line rendering
  • Added first fragment start time check to show initial line
  • Implemented line filtering based on start time relative to current playback time
  • Optimized logic for active/inactive line display

Testing:

Manual testing was performed for the following scenarios:

  • Playback start (initial line display)
  • Normal playback (gradual line appearance)
  • Forward/backward seek (correct visible line updates)
  • Scrolling (auto-scroll functionality)

Notes:

Used time-based filtering approach instead of line counter for more natural behavior and better performance.

@KVV94 KVV94 changed the title feat: update transcript logic for improved playback experience #2503 feat: update transcript logic for improved playback experience Dec 5, 2024
@Rassl Rassl merged commit 8713dec into stakwork:master Dec 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Graph Mindest] Update Transcript Logic for Improved Playback Experience
2 participants