[Fix] Update Icon and Title Rendering with New Style #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Rassl, @tomsmith8, Please review this PR. |
Rassl
reviewed
Nov 21, 2024
public/svg-icons/Logo.svg
Outdated
Rassl
reviewed
Nov 21, 2024
src/components/Icons/Logo.tsx
Outdated
There was a problem hiding this comment.
move it to header in mindset, please
Rassl
reviewed
Nov 21, 2024
| export const Header = () => { | ||
| const [title, setTitle] = useState<string>('') | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
don't need this, just render Graph mindset
There was a problem hiding this comment.
Hi @Rassl, are you referring to the hard-coded title Graph Mindset?
|
Hi @Rassl, Please review this PR.
|
Rassl
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
closes: #2456
Issue ticket number and link:
IconandTitle#2456 ]Evidence:
Acceptance Criteria