Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search_method = vector for graph/search #2324

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Add search_method = vector for graph/search #2324

merged 4 commits into from
Oct 18, 2024

Conversation

saithsab877
Copy link
Contributor

Problem:

  • Any time prediction/graph/search is called, pass search_method=vector

closes: #2295

Issue ticket number and link:

Acceptance Criteria

  • prediction/graph/search now defaults to search_method=vector.

@saithsab877
Copy link
Contributor Author

Hi @tomsmith8, @Rassl, Please review this PR.

Rassl
Rassl requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@Rassl Rassl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add this to filters property in useDataStore

@saithsab877
Copy link
Contributor Author

we should add this to filters property in useDataStore

@Rassl Fixed

@saithsab877
Copy link
Contributor Author

Hi @tomsmith8, @Rassl, Please again review this PR.

@saithsab877 saithsab877 requested a review from Rassl October 9, 2024 16:28
@saithsab877 saithsab877 requested a review from Rassl October 17, 2024 11:41
@Rassl Rassl merged commit db82448 into stakwork:master Oct 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rassl Rassl Rassl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add search_method = vector for graph/search
2 participants
@saithsab877 @Rassl