Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BluePrint]: Color Modal Overlapping UI and Difficult to Close #2319

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Shoaibdev7
Copy link
Contributor

Problem:

  • The color modal is overlapping the Create Type Modal and the Blueprint Header. Additionally, the color modal is difficult to close once opened.

We need to make it dynamic dependant on width of the screen

closes: #2299

Issue ticket number and link:

Evidence:

image

https://www.loom.com/share/94fd4a8fd4114d2fbca5385b5a194aba

Acceptance Criteria

  • The color modal should no longer overlap with other modals or headers.
  • The modal should be easier to close once opened.
  • The modal should adjust dynamically depending on screen width.

@Shoaibdev7
Copy link
Contributor Author

Hi @tomsmith8, @Rassl, Please review this PR.

@Rassl Rassl merged commit 02c0656 into stakwork:master Oct 14, 2024
16 of 17 checks passed
@tomsmith8
Copy link
Contributor

Seems like this is not fixed:

  • We should probably add a close button to ensure we can at least close if the original button is hidden
sphinx fri 18 oct 04 32 07

@Shoaibdev7
Copy link
Contributor Author

Seems like this is not fixed:

  • We should probably add a close button to ensure we can at least close if the original button is hidden

@tomsmith8, Got it! I'll add a close button to ensure it's always accessible. Thanks for the feedback!

@tomsmith8
Copy link
Contributor

Or maybe like this:

Screenshot 2024-10-18 at 16 42 49

@Shoaibdev7
Copy link
Contributor Author

Or maybe like this:

@tomsmith8, adding a close button sounds like a good solution. What’s your opinion?

@tomsmith8
Copy link
Contributor

Let's go with close button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BluePrint]: Color Modal Overlapping UI and Difficult to Close
3 participants