Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance [Sidebar]: Add External Link Button for Improved Navigation #2317

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

Shoaibdev7
Copy link
Contributor

Problem:

  • If source_link is returned, don't render the link in the list, render and icon linking out next to the label:

closes: #2314

Issue ticket number and link:

Evidence:

https://www.loom.com/share/67b69b37538442aeb3225830b1fb410b

image

image

Acceptance Criteria

  • Display an external link icon next to the label when source_link is present, opening in a new tab.

@Shoaibdev7 Shoaibdev7 closed this Oct 9, 2024
@Shoaibdev7 Shoaibdev7 deleted the Add-link-out-button-to-sidebar branch October 9, 2024 04:05
@Shoaibdev7 Shoaibdev7 restored the Add-link-out-button-to-sidebar branch October 9, 2024 04:05
@Shoaibdev7 Shoaibdev7 reopened this Oct 9, 2024
@Shoaibdev7
Copy link
Contributor Author

Hi @tomsmith8, @Rassl, Please review this PR.

@Rassl Rassl merged commit 8905e93 into stakwork:master Oct 15, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link out button to sidebar
2 participants