Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RealtimeGraph] - Flashing node edges #2283

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

Shoaibdev7
Copy link
Contributor

@Shoaibdev7 Shoaibdev7 commented Oct 2, 2024

Problem:

  • When we receive a new node or edge, the entire graph flashes when a new node and edge comes in.

closes: #2278

Issue ticket number and link:

Acceptance Criteria

  • Upon new node and edge, the lines (edges) of the new ones should flash, not the entire graph

@Shoaibdev7
Copy link
Contributor Author

Hi @Rassl, @tomsmith8, Please review this PR.

Copy link
Collaborator

@Rassl Rassl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break asa someone changes order of new lines

@Rassl
Copy link
Collaborator

Rassl commented Oct 2, 2024

this will break asa someone changes order of new lines

one solution that comes to my mind is to make each line a component, make animation on mount

@Shoaibdev7
Copy link
Contributor Author

@Rassl Ok Nice solution. I fix it and then ping you.

@Shoaibdev7
Copy link
Contributor Author

this will break asa someone changes order of new lines

one solution that comes to my mind is to make each line a component, make animation on mount

@Rassl Fixed

@Rassl Rassl merged commit 8eb8171 into stakwork:master Oct 3, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[realtimeGraph] - Flashing graph with node edge
2 participants