Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FilterSearch]: Duplicate Scroll Bar Appears in FilterSearch Modal on View More Click, Scrolls to Top on Max Results Filter Adjustment #2256

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

sophieturner0
Copy link
Contributor

@sophieturner0 sophieturner0 commented Sep 28, 2024

Problem:

  • When I click the View More button, a duplicate scroll bar appears in the FilterSearch modal.
  • When I click the Max Results filter slider, the scrollbar automatically scrolls to the top.

closes: #2253

Issue ticket number and link:

Evidence:

  • Please see the attached image as evidence.

image

Acceptance Criteria

  • Ensure only one scroll bar is visible in the FilterSearch modal when the View More button is clicked.
  • The modal should not create any unnecessary duplicate scroll bars.
  • When the Max Results filter slider is clicked, ensure the scrollbar does not automatically scroll to the top of the modal.

@sophieturner0
Copy link
Contributor Author

Hi @Rassl, @tomsmith8, Please review this PR.

@sophieturner0 sophieturner0 changed the title [FilterSearch]: Duplicate Scroll Bar appears when clicking View More button [FilterSearch]: Duplicate Scroll Bar Appears in FilterSearch Modal on View More Click, Scrolls to Top on Max Results Filter Adjustment Nov 1, 2024
@Rassl Rassl merged commit 83caf1c into stakwork:master Nov 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants