Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: undo all skipped test #2207

Merged
merged 32 commits into from
Oct 2, 2024
Merged

test: undo all skipped test #2207

merged 32 commits into from
Oct 2, 2024

Conversation

tobi-bams
Copy link
Collaborator

Ticket №:

closes #ticket_number

Problem:

insert problem you are trying to solve here

Solution:

what was the solution?

Changes:

exactly what changes did you make?

Testing:

did you add any aditional test coverage if so where and what did you test

Notes:

any additional notes

@kevkevinpal
Copy link
Collaborator

I think there are still a few tests that are not being run, not sure if we need all these or if some can be deleted

cypress/e2e/addContent/addSource.cy.ts
cypress/e2e/addNode/addNode.cy.ts
cypress/e2e/admin/topics.cy.ts
cypress/e2e/curationTable/curation.cy.ts
cypress/e2e/graph/initialRender.cy.ts
cypress/e2e/graph/searchAndRender.cy.ts
cypress/e2e/sentimentChart/sentimentAnalysis.cy.ts
cypress/e2e/sentimentChart/sentimentChart.cy.ts

@tobi-bams
Copy link
Collaborator Author

I think there are still a few tests that are not being run, not sure if we need all these or if some can be deleted

cypress/e2e/addContent/addSource.cy.ts
cypress/e2e/addNode/addNode.cy.ts
cypress/e2e/admin/topics.cy.ts
cypress/e2e/curationTable/curation.cy.ts
cypress/e2e/graph/initialRender.cy.ts
cypress/e2e/graph/searchAndRender.cy.ts
cypress/e2e/sentimentChart/sentimentAnalysis.cy.ts
cypress/e2e/sentimentChart/sentimentChart.cy.ts

Yea, but we can leave cypress/e2e/addContent/addSource.cy.ts because we need to find a way to add Twitter token without it being exposed.
cypress/e2e/admin/topics.cy.ts, cypress/e2e/curationTable/curation.cy.ts, cypress/e2e/curationTable/curation.cy.ts All this are skipped because there is an issue with how we merge node currently

@Rassl Rassl merged commit 5ad5f49 into master Oct 2, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants