Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SideBarView]: Search Text Clears When Side Panel is Collapsed #2197

Merged
merged 4 commits into from
Nov 1, 2024
Merged

[SideBarView]: Search Text Clears When Side Panel is Collapsed #2197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c0b519
fix(sid-bar): search text clears after click colllapsed button
sophieturner0 Sep 23, 2024
364c46d
Merge remote-tracking branch 'origin' into Search-Text-Clears
sophieturner0 Oct 15, 2024
0cd7594
Merge remote-tracking branch 'origin' into Search-Text-Clears
sophieturner0 Oct 17, 2024
a54b039
fix(sid-bar): search text clears after click colllapsed button
sophieturner0 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/App/SideBar/__tests__/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { ThemeProvider } from '@mui/material'
import '@testing-library/jest-dom'
import { fireEvent, render, screen, waitFor } from '@testing-library/react'
import React from 'react'
import { ThemeProvider as StyleThemeProvider } from 'styled-components'
import { MemoryRouter } from 'react-router-dom'
import { ThemeProvider as StyleThemeProvider } from 'styled-components'
import { SideBar } from '..'
import { api } from '../../../../network/api'
import { AppStore, useAppStore } from '../../../../stores/useAppStore'
Expand Down Expand Up @@ -101,7 +101,9 @@ describe('Test SideBar', () => {
</MemoryRouter>,
)

expect(container.querySelector('#sidebar-wrapper')).not.toBeInTheDocument()
waitFor(() => {
expect(container.querySelector('#sidebar-wrapper')).not.toBeInTheDocument()
})
})

it('Verify that the sidebar is visible when sidebarIsOpen is true.', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/App/SideBar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const SideBar = () => {

return (
<>
<Slide direction="right" in={sidebarIsOpen} mountOnEnter unmountOnExit>
<Slide direction="right" in={sidebarIsOpen}>
<Content subViewOpen={subViewIsOpen} />
</Slide>
<SideBarSubView open={subViewIsOpen} />
Expand Down
Loading