Fixed [BluePrint]: Create Type Modal Confirm Button Enabled Without Selecting Parent
#2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Rassl, Please review this PR. |
MirzaHanan
force-pushed
the
Confirm-Button-Disabled-Without-Select-Parent
branch
2 times, most recently
from
08737aa to
401d73a
Compare
Rassl
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Create Typemodal confirm button is enabled even when no Parent is selected, which allows submission without the necessary input.closes: #2133
Issue ticket number and link:
Create TypeModalConfirmButton Enabled Without SelectingParent#2133 ]Evidence:
https://www.loom.com/share/f39f47346b504b12b1f54f17d97a51a9
Acceptance Criteria
Create Typemodal confirm button should be disabled until a Parent is selected, and enabled only when a valid Parent is chosen.