Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed(Add-Button): Add Audio Button Next to Dropdown for Each Question #2001

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

MirzaHanan
Copy link
Contributor

@MirzaHanan MirzaHanan commented Aug 6, 2024

Problem:

  • Render audio button next to dropdown:
  • Subscribe to hook answeraudiohook
  • Render button if we receive audio_en property
  • Play/pause functionality should be the same as TLDR
  • Component should be a small icon that highlights when activated

closes: #1998

Issue ticket number and link:

Evidence:

  • Please see the attached video as evidence.

https://www.loom.com/share/6a26a6cb46f246a790958797cec6acd1

image

Acceptance Criteria

  • Subscribe to websocket answeraudiohook
  • ONLY render audio component IF hook received
  • match on ref_id
  • Play/pause functionality the same as TLDR feature
  • Component should be smaller version than TLDR as per screen shots above

@MirzaHanan
Copy link
Contributor Author

Hi @Rassl, @tomsmith8, Please review this PR.

@Rassl Rassl self-requested a review August 6, 2024 17:09
@Rassl Rassl merged commit 9c1b2da into stakwork:master Aug 6, 2024
3 of 4 checks passed
@tomsmith8
Copy link
Contributor

There seems to be an issue, the audio button has been rendered when no websocket has been sent?
image

Currently we have a button that does nothing.

The component shouldn't be visible UNLESS we receive audio_EN value from the audio hook

@tomsmith8
Copy link
Contributor

We need to subscribe to answeraudiohook as per the ticket

@tomsmith8
Copy link
Contributor

@MirzaHanan can you fix this please, thanks!

@MirzaHanan
Copy link
Contributor Author

There seems to be an issue, the audio button has been rendered when no websocket has been sent? image

Currently we have a button that does nothing.

The component shouldn't be visible UNLESS we receive audio_EN value from the audio hook

@tomsmith8 Ok

@MirzaHanan
Copy link
Contributor Author

There seems to be an issue, the audio button has been rendered when no websocket has been sent? image

Currently we have a button that does nothing.

The component shouldn't be visible UNLESS we receive audio_EN value from the audio hook

Hi @tomsmith8, this issue was caused by the exclamation mark I forgot to remove. I had added the exclamation mark just for testing purposes.

image

@tomsmith8
Copy link
Contributor

Now when the requests come in, the audio button doesn't render?

@tomsmith8
Copy link
Contributor

Are using the correct websocket subscription?

@MirzaHanan
Copy link
Contributor Author

Are using the correct websocket subscription?

@tomsmith8, Yeah I have used correct answeraudiohook websocket.

image

@tomsmith8
Copy link
Contributor

@Rassl any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add audio button next to dropdown per question
3 participants