Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On hover - render description of the entity #1866

Merged

Conversation

Shoaibdev7
Copy link
Contributor

@Shoaibdev7 Shoaibdev7 commented Jul 18, 2024

Problem:

  • on hover we should display a tooltip based on the description from the hook.

closes: #1862

Issue ticket number and link:

Evidence:

image

https://www.loom.com/share/acdc241a4d094f619521045e17b18664

@Shoaibdev7
Copy link
Contributor Author

Hi @tomsmith8, Please review this PR.

@Shoaibdev7
Copy link
Contributor Author

Hi @Rassl, @tomsmith8, Please review this PR

@Shoaibdev7 Shoaibdev7 force-pushed the On-hover-render-description-of-the-entity branch from 3d51753 to 49e2da7 Compare July 18, 2024 17:02
@Shoaibdev7
Copy link
Contributor Author

Hi @tomsmith8, @Rassl, please merge this first because this PR includes the complete functionality and UI design (ToolTip).

@Shoaibdev7
Copy link
Contributor Author

Hi @tomsmith8, @Rassl, Please review this PR.

@Shoaibdev7
Copy link
Contributor Author

@Rassl, Please review this PR.

@Shoaibdev7
Copy link
Contributor Author

@Rassl, @tomsmith8,
Please review it:
image

@Rassl Rassl self-requested a review July 18, 2024 22:10
Copy link
Collaborator

@Rassl Rassl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rassl Rassl merged commit 97a7c1b into stakwork:master Jul 18, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On hover - render description of the entity
2 participants