Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed(Change-Node): Hide node_key properties [ChangeNodeTypeModal] #1713

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Fixed(Change-Node): Hide node_key properties [ChangeNodeTypeModal] #1713

merged 4 commits into from
Jul 23, 2024

Conversation

sophieturner0
Copy link
Contributor

@sophieturner0 sophieturner0 commented Jun 22, 2024 •
edited
Loading

Problem:

  • The node_key properties are currently visible in the ChangeNodeTypeModal, which they should not be.

closes: #1703

Issue ticket number and link:

Evidence:

  • Please see the attached video as evidence.

https://www.loom.com/share/7d85e91543014a52a659d5962ca5a1a4

image

Acceptance Criteria

  • The node_key properties should be hidden from the ChangeNodeTypeModal.

@sophieturner0
Copy link
Contributor Author

Hi @Rassl, @tomsmith8,
Please take a look at this PR.

@sophieturner0
Copy link
Contributor Author

Hi @Rassl, Please merge this PR.

Rassl
Rassl approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@Rassl Rassl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rassl Rassl merged commit 3a2ddb4 into stakwork:master Jul 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rassl Rassl Rassl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide node_key properties [ChangeNodeTypeModal]
2 participants
@sophieturner0 @Rassl